Skip to content

Make all sklearn estimators concurrency-safe #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tramora merged 1 commit into from
Jan 14, 2026
Merged

Make all sklearn estimators concurrency-safe #529

tramora merged 1 commit into from
Jan 14, 2026

Conversation

@tramora
Copy link
Collaborator

@tramora tramora commented Jan 12, 2026 •
edited
Loading

Fixes #524

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@tramora tramora force-pushed the sklearn-concurrency-safe-operations branch 2 times, most recently from 1b99ecf to d2036ae Compare January 13, 2026 13:23
folmos-at-orange
folmos-at-orange approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@folmos-at-orange folmos-at-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also make better paragraphs in the tests.

popescu-v
popescu-v reviewed Jan 13, 2026
View reviewed changes
popescu-v
popescu-v requested changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments

@tramora tramora force-pushed the sklearn-concurrency-safe-operations branch from d2036ae to 8aef114 Compare January 13, 2026 15:58
popescu-v
popescu-v reviewed Jan 13, 2026
View reviewed changes
popescu-v
popescu-v reviewed Jan 13, 2026
View reviewed changes
popescu-v
popescu-v reviewed Jan 13, 2026
View reviewed changes
@tramora tramora requested a review from popescu-v January 13, 2026 17:00
Fix temporary directory race condition in sklearn estimators
94eb994 
Caution : for the tests, MPI must be disabled otherwise a segfault would occur because of a huge use of resources
@tramora tramora force-pushed the sklearn-concurrency-safe-operations branch from 8aef114 to 94eb994 Compare January 13, 2026 17:02
@tramora tramora merged commit cfb2d61 into dev Jan 14, 2026
18 checks passed
@tramora tramora deleted the sklearn-concurrency-safe-operations branch January 14, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@popescu-v popescu-v popescu-v approved these changes

@folmos-at-orange folmos-at-orange Awaiting requested review from folmos-at-orange

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Temporary directory handling renders sklearn estimators non-thread safe

4 participants

@tramora @folmos-at-orange @popescu-v