Merge 4.0.1 to main#103
Closed
indrora wants to merge 2 commits into
Closed
Conversation
--------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> Co-authored-by: Lee Fine <lfine@keyfactor.com>
* ab#84031 * Update generated docs --------- Co-authored-by: Lee Fine <lfine@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
There was a problem hiding this comment.
Pull request overview
Automated merge of the release-4.0 line into main, bringing in RemoteFile Orchestrator v4.0.1 updates (post-job command support, store type/script updates, and documentation/manifest changes).
Changes:
- Add “post job command” capability (config + custom field + execution after Management-Add/ODKG).
- Update Linux store creation behavior (derive permissions/owner from parent folder when unset) and expand allowed path characters.
- Add generated store-type creation scripts (kfutil/curl/PowerShell) and update docs/assets/manifests/changelog.
Reviewed changes
Copilot reviewed 16 out of 134 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/store_types/powershell/restmethod_create_store_types.ps1 | Adds generated PowerShell REST-based store type creation script. |
| scripts/store_types/powershell/kfutil_create_store_types.ps1 | Adds generated PowerShell kfutil-based store type creation script. |
| scripts/store_types/bash/kfutil_create_store_types.sh | Adds generated bash kfutil-based store type creation script. |
| scripts/store_types/bash/curl_create_store_types.sh | Adds generated bash curl-based store type creation script with OAuth/basic auth support. |
| integration-manifest.json | Adds PostJobApplicationRestart field definitions/options to store types. |
| docsource/images/RFPEM-custom-field-LinuxFilePermissionsOnStoreCreation-validation-options-dialog.png | Adds documentation image asset. |
| docsource/images/RFORA-custom-field-LinuxFilePermissionsOnStoreCreation-validation-options-dialog.png | Adds documentation image asset. |
| docsource/images/RFKDB-custom-field-LinuxFilePermissionsOnStoreCreation-validation-options-dialog.png | Adds documentation image asset. |
| docsource/images/RFJKS-custom-field-LinuxFilePermissionsOnStoreCreation-validation-options-dialog.png | Adds documentation image asset. |
| docsource/images/RFDER-custom-field-LinuxFilePermissionsOnStoreCreation-validation-options-dialog.png | Adds documentation image asset. |
| docsource/content.md | Updates documentation for new PostJobCommands configuration and behavior. |
| RemoteFile/config.json | Seeds PostJobCommands configuration entries. |
| RemoteFile/RemoteHandlers/LinuxLocalHandler.cs | Updates Linux local store file creation behavior and adds helper methods. |
| RemoteFile/RemoteFileJobTypeBase.cs | Adds/reads PostJobApplicationRestart store property and logs it. |
| RemoteFile/RemoteCertificateStore.cs | Adds post-job command execution + DER-to-PKCS12 conversion helper and path regex update. |
| RemoteFile/ReenrollmentBase.cs | Hooks post-job command execution after reenrollment add and adjusts PFX export. |
| RemoteFile/ManagementBase.cs | Hooks post-job command execution after management add and adjusts thumbprint derivation. |
| RemoteFile/ImplementedStoreTypes/OraWlt/OraWltCertificateStoreSerializer.cs | Adjusts RunCommand masking to include store password. |
| RemoteFile/ApplicationSettings.cs | Extends config parsing to support PostJobCommands array. |
| README.md | Updates docs for new custom field and configuration + additional screenshots. |
| CHANGELOG.md | Adds v4.0.1 and v4.0.0 entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge release-4.0 to main - Automated PR