Bug Fix: Initializing _certDataReader#9
Merged
indrora merged 11 commits intorelease-1.0from Jan 8, 2026
Merged
Conversation
Contributor
joevanwanzeeleKF
commented
Oct 29, 2025
joevanwanzeeleKF
commented
- bug fix: _certDataReader is now initialized in the Initialize method
… version of the integration
…sm for getting product ID's. Added check for a null response.
There was a problem hiding this comment.
Pull request overview
This PR addresses a bug where the _certDataReader field was not being initialized in the Initialize method, along with multiple improvements to API response handling, logging, and spelling corrections throughout the codebase. The changes also update package dependencies and refactor how Vault API responses are deserialized by properly handling the wrapped response format.
Key changes:
- Fixed bug where
_certificateDataReaderwas not initialized in the Initialize method (line 57) - Changed
RevocationTimefromDateTime?tostringinCertResponseto properly handle RFC3339 formatted timestamps from Vault API - Updated multiple package dependencies to newer versions, including several to version 10.0.0
- Refactored Vault API calls to use
WrappedResponse<T>wrapper for proper deserialization of nested response data - Corrected multiple spelling errors ("retreive" → "retrieve", "successfule" → "successful")
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| hashicorp-vault-cagateway/HashicorpVaultCAConnector.cs | Initializes _certificateDataReader, adds assembly version logging, changes RevocationTime handling from DateTime to string, fixes spelling errors, adds cancellation token to sync operations |
| hashicorp-vault-cagateway/Client/VaultHttp.cs | Enhanced logging, improved deserialization handling, fixed error message terminology |
| hashicorp-vault-cagateway/Client/HashicorpVaultClient.cs | Refactored to use WrappedResponse wrapper for API calls, fixed spelling in documentation |
| hashicorp-vault-cagateway/APIProxy/WrappedResponse.cs | Added RequestId and MountType properties to match Vault API response structure |
| hashicorp-vault-cagateway/APIProxy/CertResponse.cs | Changed RevocationTime from DateTime? to string, added RevocationTimestamp property |
| hashicorp-vault-cagateway/hashicorp-vault-caplugin.csproj | Updated package versions and added Microsoft.Extensions.Logging.Abstractions, removed Resources configuration |
| hashicorp-vault-cagateway/Properties/launchSettings.json | Removed launch settings file |
| readme_source.md | Fixed spelling error in documentation |
| CHANGELOG.md | Added entry documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.