Skip to content

feat(auth): Add support for windows grant type.#14

Merged
indrora merged 9 commits intorelease-1.2from
ab#80540
Feb 25, 2026
Merged

feat(auth): Add support for windows grant type.#14
indrora merged 9 commits intorelease-1.2from
ab#80540

Conversation

@spbsoluble
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 6, 2026 19:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for Integrated Windows Authentication (IWA) by introducing a new windows grant type to the Delinea Secret Server PAM Provider.

Key changes:

  • Added windows as a third supported grant type alongside password and client_credentials
  • Implemented Windows authentication flow using default credentials via HttpClientHandler
  • Updated validation logic to support Windows authentication without requiring explicit credentials
  • Enhanced error handling with specific Windows authentication exceptions

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
CHANGELOG.md Added changelog entry documenting the new Windows grant type feature
README.md Added comprehensive documentation with example configuration for Windows authentication
docsource/overview.md Added authentication methods section with Windows grant type examples
delinea-secretserver-pam/manifest.json Updated GrantType to include windows option
delinea-secretserver-pam/SecretServerPam.cs Core implementation of Windows authentication flow with specialized URL path, error handling, and HttpClient configuration
delinea-secretserver-pam/Models/DelineaConfiguration.cs Updated validation logic to handle Windows grant type with proper credential requirements
TestConsole/Program.cs Added case handling for windows grant type in test console
Comments suppressed due to low confidence (1)

delinea-secretserver-pam/SecretServerPam.cs:418

  • The error message contains an inconsistency. It mentions only 'password' and 'client_credentials' but should also include 'windows' as a supported grant type to be accurate with the current implementation.
                    Logger.LogError(
                        "Invalid grant type '{GrantType}' specified. Supported types are 'password' and 'client_credentials'",
                        grantType);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread delinea-secretserver-pam/Models/DelineaConfiguration.cs Outdated
Comment thread delinea-secretserver-pam/SecretServerPam.cs
Comment thread delinea-secretserver-pam/SecretServerPam.cs Outdated
Comment thread delinea-secretserver-pam/SecretServerPam.cs Outdated
Comment thread delinea-secretserver-pam/SecretServerPam.cs Outdated
Comment thread README.md Outdated
Comment thread docsource/overview.md Outdated
Comment thread delinea-secretserver-pam/SecretServerPam.cs Outdated
spbsoluble and others added 7 commits February 16, 2026 09:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@indrora indrora merged commit e5b7058 into release-1.2 Feb 25, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants