feat(auth): Add support for windows grant type.#14
Merged
indrora merged 9 commits intorelease-1.2from Feb 25, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for Integrated Windows Authentication (IWA) by introducing a new windows grant type to the Delinea Secret Server PAM Provider.
Key changes:
- Added
windowsas a third supported grant type alongsidepasswordandclient_credentials - Implemented Windows authentication flow using default credentials via HttpClientHandler
- Updated validation logic to support Windows authentication without requiring explicit credentials
- Enhanced error handling with specific Windows authentication exceptions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Added changelog entry documenting the new Windows grant type feature |
| README.md | Added comprehensive documentation with example configuration for Windows authentication |
| docsource/overview.md | Added authentication methods section with Windows grant type examples |
| delinea-secretserver-pam/manifest.json | Updated GrantType to include windows option |
| delinea-secretserver-pam/SecretServerPam.cs | Core implementation of Windows authentication flow with specialized URL path, error handling, and HttpClient configuration |
| delinea-secretserver-pam/Models/DelineaConfiguration.cs | Updated validation logic to handle Windows grant type with proper credential requirements |
| TestConsole/Program.cs | Added case handling for windows grant type in test console |
Comments suppressed due to low confidence (1)
delinea-secretserver-pam/SecretServerPam.cs:418
- The error message contains an inconsistency. It mentions only 'password' and 'client_credentials' but should also include 'windows' as a supported grant type to be accurate with the current implementation.
Logger.LogError(
"Invalid grant type '{GrantType}' specified. Supported types are 'password' and 'client_credentials'",
grantType);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.