refactor: Update core internals: thread safety, HTTP client abstraction, and cleanup of dead code#262
Open
akash-vijay-kv wants to merge 15 commits intodevelopfrom
Open
refactor: Update core internals: thread safety, HTTP client abstraction, and cleanup of dead code#262akash-vijay-kv wants to merge 15 commits intodevelopfrom
akash-vijay-kv wants to merge 15 commits intodevelopfrom
Conversation
* [NET-701] fix: Cleanup and fix custom ADK instrumentation * fix: Capture llm spans from adk with proper input and output attributes * fix: Update tool invocation spans for ADK instrumentation with input and output attributes * fix: Code cleanup and sdk version update * fix: Merge thought tokens and candidate tokens as completion tokens * fix: reduce TTFT discrepancy between ADK and nested Google GenAI span * fix: Remove thoughts_token_count from ADK span attributes * fix: Code cleanup and bug fix
… tear-down (#260) * feat: Add graceful HTTP client cleanup * refactor: Add exception handling for span lifecycle management utilities
akash-vijay-kv
force-pushed
the
develop
branch
2 times, most recently
from
3ab169b to
c6dcef4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
fix: Remove duplicate
__all__assignments and dead codefix: Avoid import-time evaluation of start time
fix: Ensure thread safety in
SessionManagerand span mapsfeat: Introduce base HTTP client provider & refactor streaming spans