Skip to content

fix: add question mark operator to getValue in filterFns #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alessandrojcm merged 1 commit into from
Jan 27, 2025
Merged

fix: add question mark operator to getValue in filterFns #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/mantine-react-table/src/fns/filterFns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const contains = <TData extends MRT_RowData>(
) =>
row
.getValue<number | string>(id)
.toString()
?.toString()
.toLowerCase()
.trim()
.includes(filterValue.toString().toLowerCase().trim());
Expand All @@ -47,7 +47,7 @@ const startsWith = <TData extends MRT_RowData>(
) =>
row
.getValue<number | string>(id)
.toString()
?.toString()
.toLowerCase()
.trim()
.startsWith(filterValue.toString().toLowerCase().trim());
Expand All @@ -61,7 +61,7 @@ const endsWith = <TData extends MRT_RowData>(
) =>
row
.getValue<number | string>(id)
.toString()
?.toString()
.toLowerCase()
.trim()
.endsWith(filterValue.toString().toLowerCase().trim());
Expand All @@ -73,7 +73,7 @@ const equals = <TData extends MRT_RowData>(
id: string,
filterValue: number | string,
) =>
row.getValue<number | string>(id).toString().toLowerCase().trim() ===
row.getValue<number | string>(id)?.toString().toLowerCase().trim() ===
filterValue?.toString().toLowerCase().trim();

equals.autoRemove = (val: any) => !val;
Expand All @@ -83,7 +83,7 @@ const notEquals = <TData extends MRT_RowData>(
id: string,
filterValue: number | string,
) =>
row.getValue<number | string>(id).toString().toLowerCase().trim() !==
row.getValue<number | string>(id)?.toString().toLowerCase().trim() !==
filterValue.toString().toLowerCase().trim();

notEquals.autoRemove = (val: any) => !val;
Expand All @@ -95,7 +95,7 @@ const greaterThan = <TData extends MRT_RowData>(
) =>
!isNaN(+filterValue) && !isNaN(+row.getValue<number | string>(id))
? +row.getValue<number | string>(id) > +filterValue
: row.getValue<number | string>(id).toString().toLowerCase().trim() >
: row.getValue<number | string>(id)?.toString().toLowerCase().trim() >
filterValue?.toString().toLowerCase().trim();

greaterThan.autoRemove = (val: any) => !val;
Expand All @@ -115,7 +115,7 @@ const lessThan = <TData extends MRT_RowData>(
) =>
!isNaN(+filterValue) && !isNaN(+row.getValue<number | string>(id))
? +row.getValue<number | string>(id) < +filterValue
: row.getValue<number | string>(id).toString().toLowerCase().trim() <
: row.getValue<number | string>(id)?.toString().toLowerCase().trim() <
filterValue?.toString().toLowerCase().trim();

lessThan.autoRemove = (val: any) => !val;
Expand Down Expand Up @@ -162,15 +162,15 @@ const empty = <TData extends MRT_RowData>(
row: Row<TData>,
id: string,
_filterValue: number | string,
) => !row.getValue<number | string>(id).toString().trim();
) => !row.getValue<number | string>(id)?.toString().trim();

empty.autoRemove = (val: any) => !val;

const notEmpty = <TData extends MRT_RowData>(
row: Row<TData>,
id: string,
_filterValue: number | string,
) => !!row.getValue<number | string>(id).toString().trim();
) => !!row.getValue<number | string>(id)?.toString().trim();

notEmpty.autoRemove = (val: any) => !val;

Expand Down
Loading