Orhan week 3 #39
Open
Orhan week 3 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashaghel
reviewed
Oct 1, 2020
| const attributes = [searchName] | ||
| const sql1 = "select p.product_name, pa.unit_price, s.supplier_name from product_availability pa join products p on pa.prod_id = p.id join suppliers s on pa.supp_id = s.id where Lower(p.product_name) like '%'|| $1 ||'%'"; | ||
| const sql2 = 'select p.product_name, pa.unit_price, s.supplier_name from product_availability pa join products p on pa.prod_id = p.id join suppliers s on pa.supp_id = s.id'; | ||
|
|
There was a problem hiding this comment.
while this will work with no issue
it can be harder to maintain and scale up
for better fix you can have arguments and where conditions alone as variables that are added to main string on a conditions
| const prod_id = req.body.prod_id; | ||
| const supp_id = req.body.supp_id; | ||
| const price = req.body.unit_price; | ||
| if (price < 0) { |
There was a problem hiding this comment.
casting price from string to number
also a check for integers ?
| const sql_supp = "select * from product_availability where supp_id = $1" | ||
| db.query(sql_supp, [supp_id], (err, result) => { | ||
| if (err || result.rows.length == 0) { | ||
| res.status(500).send(err, "Didnt match foreign key supp_id") |
There was a problem hiding this comment.
a much friendlier message is usually sent to the user, you never send db secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.