초대 공유 도메인 변경#165
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthrough이 PR은 초대 딥링크 시스템의 도메인을 변경하고 초대 공유 메시지 포맷을 단순화합니다. AndroidManifest의 intent-filter 호스트와 InviteLaunchDispatcher의 도메인 상수를 keepiluv.teamtwix.com으로 통일하며, 공유 메시지 리소스에서 플레이스토어 URL 플레이스홀더를 제거하고 CoupleConnectScreen에서 해당 인자 전달을 제거합니다. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core/share/src/androidTest/java/com/twix/share/InviteLaunchDispatcherAndroidTest.kt (1)
12-23: ⚡ Quick win딥링크 디스패치의 Sad Path 테스트도 같이 추가해 주세요.
현재는 정상 URL만 검증되어
host/path/scheme분기 회귀를 놓칠 수 있습니다.wrong host,wrong path,ACTION_VIEW 아님케이스에서pendingInviteCode가null로 유지되는지 1~2개만 추가하면 안정성이 크게 올라갑니다.As per coding guidelines, "/test/: Happy / Sad Path가 모두 커버되는가?"를 충족하려면 부정 경로 검증이 함께 필요합니다.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core/share/src/androidTest/java/com/twix/share/InviteLaunchDispatcherAndroidTest.kt` around lines 12 - 23, Add sad-path unit tests for InviteLaunchDispatcher to ensure pendingInviteCode stays null for invalid intents: create tests that call InviteLaunchDispatcher().dispatchFromIntent(...) with (1) an ACTION_VIEW Intent whose data Uri has a wrong host (e.g., not "keepiluv.teamtwix.com"), (2) an ACTION_VIEW Intent with the wrong path (not "/invite"), and/or (3) a non-ACTION_VIEW Intent, then assert dispatcher.pendingInviteCode.value is null after each dispatch; reference InviteLaunchDispatcher, dispatchFromIntent, pendingInviteCode, Intent.ACTION_VIEW and the INVITE_CODE constant to mirror the existing happy-path test structure.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@core/share/src/androidTest/java/com/twix/share/InviteLaunchDispatcherAndroidTest.kt`:
- Around line 12-23: Add sad-path unit tests for InviteLaunchDispatcher to
ensure pendingInviteCode stays null for invalid intents: create tests that call
InviteLaunchDispatcher().dispatchFromIntent(...) with (1) an ACTION_VIEW Intent
whose data Uri has a wrong host (e.g., not "keepiluv.teamtwix.com"), (2) an
ACTION_VIEW Intent with the wrong path (not "/invite"), and/or (3) a
non-ACTION_VIEW Intent, then assert dispatcher.pendingInviteCode.value is null
after each dispatch; reference InviteLaunchDispatcher, dispatchFromIntent,
pendingInviteCode, Intent.ACTION_VIEW and the INVITE_CODE constant to mirror the
existing happy-path test structure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0c6b1327-6a83-410e-99c8-891f7420367a
📒 Files selected for processing (6)
app/src/main/AndroidManifest.xmlcore/design-system/src/main/res/values/strings.xmlcore/share/src/androidTest/java/com/twix/share/InviteLaunchDispatcherAndroidTest.ktcore/share/src/main/java/com/twix/share/InviteLaunchDispatcher.ktcore/share/src/test/java/com/twix/share/InviteLaunchDispatcherTest.ktfeature/onboarding/src/main/java/com/twix/onboarding/couple/CoupleConnectScreen.kt
💤 Files with no reviewable changes (1)
- feature/onboarding/src/main/java/com/twix/onboarding/couple/CoupleConnectScreen.kt
이슈 번호
#162
작업내용
결과물
리뷰어에게 추가로 요구하는 사항 (선택)