Skip to content

초대 공유 도메인 변경#165

Merged
chanho0908 merged 3 commits into
developfrom
fix/#164-invite-share-domain
May 30, 2026
Merged

초대 공유 도메인 변경#165
chanho0908 merged 3 commits into
developfrom
fix/#164-invite-share-domain

Conversation

@chanho0908
Copy link
Copy Markdown
Contributor

@chanho0908 chanho0908 commented May 21, 2026

이슈 번호

#162

작업내용

  • 초대장 메시지에 플레이 스토어 링크 첨부 제거
  • 초대장 도메인 수정

결과물

Before After
KakaoTalk_Photo_2026-05-21-14-42-27 ㄹㅁㅅㄷㄱ

리뷰어에게 추가로 요구하는 사항 (선택)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 60f93ad9-5011-4ff4-bfba-b192e696301a

📥 Commits

Reviewing files that changed from the base of the PR and between 26314bf and 5da9199.

📒 Files selected for processing (1)
  • core/navigation-contract/src/main/java/com/twix/navigation_contract/Constants.kt
💤 Files with no reviewable changes (1)
  • core/navigation-contract/src/main/java/com/twix/navigation_contract/Constants.kt

📝 Walkthrough

Walkthrough

이 PR은 초대 딥링크 시스템의 도메인을 변경하고 초대 공유 메시지 포맷을 단순화합니다. AndroidManifest의 intent-filter 호스트와 InviteLaunchDispatcher의 도메인 상수를 keepiluv.teamtwix.com으로 통일하며, 공유 메시지 리소스에서 플레이스토어 URL 플레이스홀더를 제거하고 CoupleConnectScreen에서 해당 인자 전달을 제거합니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경사항의 핵심(초대 공유 도메인 변경)을 명확하고 간결하게 요약하고 있습니다.
Description check ✅ Passed PR 설명이 작업 내용(플레이 스토어 링크 제거, 도메인 수정)과 Before/After 결과물을 포함하여 변경사항과 관련된 정보를 충분히 제공하고 있습니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#164-invite-share-domain

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
core/share/src/androidTest/java/com/twix/share/InviteLaunchDispatcherAndroidTest.kt (1)

12-23: ⚡ Quick win

딥링크 디스패치의 Sad Path 테스트도 같이 추가해 주세요.

현재는 정상 URL만 검증되어 host/path/scheme 분기 회귀를 놓칠 수 있습니다. wrong host, wrong path, ACTION_VIEW 아님 케이스에서 pendingInviteCodenull로 유지되는지 1~2개만 추가하면 안정성이 크게 올라갑니다.

As per coding guidelines, "/test/: Happy / Sad Path가 모두 커버되는가?"를 충족하려면 부정 경로 검증이 함께 필요합니다.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@core/share/src/androidTest/java/com/twix/share/InviteLaunchDispatcherAndroidTest.kt`
around lines 12 - 23, Add sad-path unit tests for InviteLaunchDispatcher to
ensure pendingInviteCode stays null for invalid intents: create tests that call
InviteLaunchDispatcher().dispatchFromIntent(...) with (1) an ACTION_VIEW Intent
whose data Uri has a wrong host (e.g., not "keepiluv.teamtwix.com"), (2) an
ACTION_VIEW Intent with the wrong path (not "/invite"), and/or (3) a
non-ACTION_VIEW Intent, then assert dispatcher.pendingInviteCode.value is null
after each dispatch; reference InviteLaunchDispatcher, dispatchFromIntent,
pendingInviteCode, Intent.ACTION_VIEW and the INVITE_CODE constant to mirror the
existing happy-path test structure.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@core/share/src/androidTest/java/com/twix/share/InviteLaunchDispatcherAndroidTest.kt`:
- Around line 12-23: Add sad-path unit tests for InviteLaunchDispatcher to
ensure pendingInviteCode stays null for invalid intents: create tests that call
InviteLaunchDispatcher().dispatchFromIntent(...) with (1) an ACTION_VIEW Intent
whose data Uri has a wrong host (e.g., not "keepiluv.teamtwix.com"), (2) an
ACTION_VIEW Intent with the wrong path (not "/invite"), and/or (3) a
non-ACTION_VIEW Intent, then assert dispatcher.pendingInviteCode.value is null
after each dispatch; reference InviteLaunchDispatcher, dispatchFromIntent,
pendingInviteCode, Intent.ACTION_VIEW and the INVITE_CODE constant to mirror the
existing happy-path test structure.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c6b1327-6a83-410e-99c8-891f7420367a

📥 Commits

Reviewing files that changed from the base of the PR and between b29d219 and 26314bf.

📒 Files selected for processing (6)
  • app/src/main/AndroidManifest.xml
  • core/design-system/src/main/res/values/strings.xml
  • core/share/src/androidTest/java/com/twix/share/InviteLaunchDispatcherAndroidTest.kt
  • core/share/src/main/java/com/twix/share/InviteLaunchDispatcher.kt
  • core/share/src/test/java/com/twix/share/InviteLaunchDispatcherTest.kt
  • feature/onboarding/src/main/java/com/twix/onboarding/couple/CoupleConnectScreen.kt
💤 Files with no reviewable changes (1)
  • feature/onboarding/src/main/java/com/twix/onboarding/couple/CoupleConnectScreen.kt

@chanho0908 chanho0908 self-assigned this May 21, 2026
@chanho0908 chanho0908 added the Refactor Good for newcomers label May 21, 2026
@chanho0908 chanho0908 requested a review from dogmania May 21, 2026 09:38
@chanho0908 chanho0908 merged commit 2b74cd4 into develop May 30, 2026
4 checks passed
@chanho0908 chanho0908 deleted the fix/#164-invite-share-domain branch May 30, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants