GUIでキーボード高さを低く設定すると、実際のキーボードの高さが変動するバグを修正。#666
Open
3pino wants to merge 2 commits intoKazumaProject:mainfrom
Open
GUIでキーボード高さを低く設定すると、実際のキーボードの高さが変動するバグを修正。#6663pino wants to merge 2 commits intoKazumaProject:mainfrom
3pino wants to merge 2 commits intoKazumaProject:mainfrom
Conversation
キーボード高さの計算ロジックを統一して、文字入力前後の距離が変わるバグを解決。 -setKeyboardHeightWithAdditionalOriginal関数を削除 -setKeyboardHeightWithAdditionalをupdateKeyboardLayoutに統一
- テンキー、QWERTY共に最小値を100dpに統一 - 縦向き(portrait)での最小値を180dpから100dpに修正 - GUI設定画面との一貫性を確保
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
バグの再現
この手順3 の挙動を改善しました。
原因
setKeyboardHeightWithAdditionalOriginal関数とupdateKeyboardLayoutが混在していました。また、高さの最小値制限が不統一でした。
修正内容
setKeyboardHeightWithAdditional関数を統一されたupdateKeyboardLayoutに変更