Skip to content

Default validator relative error #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkreitz merged 2 commits into from
May 25, 2026
Merged

Default validator relative error #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0f4acf
Make default validator output relative error
Matistjati May 25, 2026
8f733ef
Update default validator float tests
Matistjati May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions support/default_validator/default_validator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,24 @@ int main(int argc, char **argv) {
// gone very wrong if we're dealing with floats so long we need to truncate anyway :)
judge_trunc = truncate(judge);
team_trunc = truncate(team);
wrong_answer("Too large difference.\n Judge: %s\n User: %s\n Difference: %le\n (abs tol %le rel tol %le)",
judge_trunc.c_str(), team_trunc.c_str(), jval-tval, float_abs_tol, float_rel_tol);
if (jval == 0.0) {
wrong_answer("Too large difference.\n"
" Judge: %s\n"
" User: %s\n"
" Absolute error: %le (abs tolerance %le)\n"
" Relative error: undefined, judge value is 0 (rel tolerance %le)",
judge_trunc.c_str(), team_trunc.c_str(),
fabs(jval - tval), float_abs_tol, float_rel_tol);
} else {
wrong_answer("Too large difference.\n"
" Judge: %s\n"
" User: %s\n"
" Absolute error: %le (abs tolerance %le)\n"
" Relative error: %le (rel tolerance %le)",
judge_trunc.c_str(), team_trunc.c_str(),
fabs(jval - tval), float_abs_tol,
fabs(jval - tval) / fabs(jval), float_rel_tol);
}
}
} else if (case_sensitive) {
if (strcmp(judge.c_str(), team.c_str()) != 0) {
Expand Down
6 changes: 3 additions & 3 deletions tests/default_validator_tests/test_combined_flags_wa/expected_message.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Wrong answer on line 1 of output (corresponding to line 1 in answer file)
Too large difference.
Judge: 1.0
User: 2.0
Difference: -1.000000e+00
(abs tol 5.000000e-01 rel tol 5.000000e-01)
User: 2.0
Absolute error: 1.000000e+00 (abs tolerance 5.000000e-01)
Relative error: 1.000000e+00 (rel tolerance 5.000000e-01)
6 changes: 3 additions & 3 deletions tests/default_validator_tests/test_float_abs_tol_wa/expected_message.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Wrong answer on line 1 of output (corresponding to line 1 in answer file)
Too large difference.
Judge: 1
User: 1.4
Difference: -4.000000e-01
(abs tol 1.000000e-01 rel tol -1.000000e+00)
User: 1.4
Absolute error: 4.000000e-01 (abs tolerance 1.000000e-01)
Relative error: 4.000000e-01 (rel tolerance -1.000000e+00)
6 changes: 3 additions & 3 deletions tests/default_validator_tests/test_float_rel_tol_wa/expected_message.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Wrong answer on line 1 of output (corresponding to line 1 in answer file)
Too large difference.
Judge: 100
User: 105
Difference: -5.000000e+00
(abs tol -1.000000e+00 rel tol 1.000000e-02)
User: 105
Absolute error: 5.000000e+00 (abs tolerance -1.000000e+00)
Relative error: 5.000000e-02 (rel tolerance 1.000000e-02)
6 changes: 3 additions & 3 deletions tests/default_validator_tests/test_float_tolerance_wa/expected_message.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Wrong answer on line 1 of output (corresponding to line 1 in answer file)
Too large difference.
Judge: 1
User: 1.50001
Difference: -5.000100e-01
(abs tol 5.000000e-01 rel tol 5.000000e-01)
User: 1.50001
Absolute error: 5.000100e-01 (abs tolerance 5.000000e-01)
Relative error: 5.000100e-01 (rel tolerance 5.000000e-01)
1 change: 1 addition & 0 deletions tests/default_validator_tests/test_float_zero_judge_wa/args.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
float_relative_tolerance 0.01
1 change: 1 addition & 0 deletions tests/default_validator_tests/test_float_zero_judge_wa/expected_exit_code.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
43
6 changes: 6 additions & 0 deletions tests/default_validator_tests/test_float_zero_judge_wa/expected_message.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Wrong answer on line 1 of output (corresponding to line 1 in answer file)
Too large difference.
Judge: 0
User: 1
Absolute error: 1.000000e+00 (abs tolerance -1.000000e+00)
Relative error: undefined, judge value is 0 (rel tolerance 1.000000e-02)
1 change: 1 addition & 0 deletions tests/default_validator_tests/test_float_zero_judge_wa/judge.ans
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0
1 change: 1 addition & 0 deletions tests/default_validator_tests/test_float_zero_judge_wa/user.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1