fix(quality): resolve cs-fixer formatting + Psalm PossiblyFalseOperand#17
Merged
walmir-silva merged 1 commit intomainfrom Mar 2, 2026
Merged
fix(quality): resolve cs-fixer formatting + Psalm PossiblyFalseOperand#17walmir-silva merged 1 commit intomainfrom
walmir-silva merged 1 commit intomainfrom
Conversation
cs-fixer: removed extra alignment spaces in array key-value pairs across 6 files (KcodeComposerGenerator, Devkit, InitCommand, ProcessExecutor, KcodeComposerGeneratorTest, ComposerResolverTest). No logic changes. KcodeComposerGenerator.php:76: json_encode() returns false|string; applied (string) cast to satisfy Psalm PossiblyFalseOperand. The manifest is a static structure with no un-serializable values so the false branch is unreachable in practice. Result: ✓ cs-fixer passed ✓ phpstan passed ✓ psalm passed (0 errors) ✓ phpunit passed ✓ All 4 tool(s) passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cs-fixer: removed extra alignment spaces in array key-value pairs across 6 files (KcodeComposerGenerator, Devkit, InitCommand, ProcessExecutor, KcodeComposerGeneratorTest, ComposerResolverTest). No logic changes.
KcodeComposerGenerator.php:76:
json_encode() returns false|string; applied (string) cast to satisfy
Psalm PossiblyFalseOperand. The manifest is a static structure with no
un-serializable values so the false branch is unreachable in practice.
Result:
✓ cs-fixer passed
✓ phpstan passed
✓ psalm passed (0 errors)
✓ phpunit passed
✓ All 4 tool(s) passed