refactor: move coloring logic into `coloring.rs`, tighten visibility#342

Closed

Copilot wants to merge 43 commits intomasterfrom

copilot/add-todos-for-main-pr

Commits on Mar 7, 2026

Initial plan
Copilot
committed
Initial plan
Copilot
committed
Add --color flag and Visualizer coloring support

Copilot
and
KSXGitHub
committed
Address review feedback: Color enum, minimize const visibility, simplify rendering

Copilot
and
KSXGitHub
committed
Address second review round: rename Colorless→Normal, refactor is_dir, update docs

Copilot
and
KSXGitHub
committed
Address third review round: ColoredSlice, rename coloring_map/is_dir, remove redundant attributes

Copilot
and
KSXGitHub
committed
feat: lscolors integration, multi-color support, render_row macro, destructure TreeHorizontalSlice

Copilot
and
KSXGitHub
committed
refactor: single LazyLock<AnsiPrefixes> + format_args! with row destructuring

Copilot
and
KSXGitHub
committed
refactor: rename aligned_colored/aligned_normal to aligned_colored_slice/aligned_plain_slice

Copilot
and
KSXGitHub
committed
refactor: consolidate AnsiPrefixes at crate root; Coloring struct; ColoredTreeHorizontalSlice

Copilot
and
KSXGitHub
committed
refactor(r7): rename AnsiPrefixes→LsColors, private fields, restructure coloring, move color logic to App::run

Copilot
and
KSXGitHub
committed
refactor(r8): rename field, minimize visibility, move color calc, diverse-kinds workspace, fix tests

Copilot
and
KSXGitHub
committed
test: add predefined LS_COLORS constant to color tests

Copilot
and
KSXGitHub
committed
Replace unsafe set_var in color_always test with LsColors FromStr

Copilot
and
KSXGitHub
committed
Address review comments: refactor LsColors, add color test without LS_COLORS

Copilot
and
KSXGitHub
committed
fix: rename LsColors::from_str to from_ls_colors_string to fix clippy lint

Copilot
and
KSXGitHub
committed
fix: use full PathBuf key in build_coloring_map to prevent basename collision

Copilot
and
KSXGitHub
committed
chore: remove dead src/ansi_prefixes.rs file

Copilot
and
KSXGitHub
committed
refactor: address review threads 71-75: remove Hash+Eq bounds, rename ansi_prefixes to ls_colors, update doc comment, make lscolors optional under color feature

Copilot
and
KSXGitHub
committed
revert: remove color feature flag, make lscolors an unconditional dependency

Copilot
and
KSXGitHub
committed
refactor: use Vec<OsString> as coloring map keys instead of PathBuf

Copilot
and
KSXGitHub
committed
feat: use `from_str`

KSXGitHub
authored and
Copilot
committed
refactor: use `.without_env`

KSXGitHub
authored and
Copilot
committed
fix: fmt

KSXGitHub
authored and
Copilot
committed
style: merge imports

KSXGitHub
authored and
Copilot
committed
test: rename a test

KSXGitHub
authored and
Copilot
committed
test: change the workspace

KSXGitHub
authored and
Copilot
committed
refactor: shorten an expression

KSXGitHub
authored and
Copilot
committed
refactor: rearrange

KSXGitHub
authored and
Copilot
committed
refactor: correct a name

KSXGitHub
authored and
Copilot
committed
perf: reduce unnecessary allocations

KSXGitHub
authored and
Copilot
committed
refactor: replace qualified path with `use`

KSXGitHub
authored and
Copilot
committed
refactor: use `.pipe_as_ref`

KSXGitHub
authored and
Copilot
committed
refactor: rename a variable

KSXGitHub
authored and
Copilot
committed
feat: hide some APIs

KSXGitHub
authored and
Copilot
committed
refactor: remove `format_args!`

KSXGitHub
authored and
Copilot
committed
refactor: deduplicate code

KSXGitHub
authored and
Copilot
committed
docs: add some TODOs

KSXGitHub
authored and
Copilot
committed
docs: missing docs

KSXGitHub
authored and
Copilot
committed
refactor: correct a name

KSXGitHub
authored and
Copilot
committed
feat: hide `AnsiPrefix`

KSXGitHub
authored and
Copilot
committed
refactor: add some TODOs

KSXGitHub
authored and
Copilot
committed
refactor: resolve TODOs - move coloring logic into coloring.rs

Copilot
and
KSXGitHub
committed