Feature/demo/mochi#154
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new demo page at /demo/mochi-k18 with associated styles and registers the demo link in the demo index. Includes a Next.js page component, two CSS files (global and CSS-module), and an avatar image usage. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
requested review from
SakaYq4875,
katsumata68 and
rotarymars
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/app/demo/mochi-k18/page.html`:
- Line 1: The DOCTYPE declaration is misspelled; replace the incorrect
"<!DOCTIPE html>" with the correct "<!DOCTYPE html>" at the top of the document
(the page's HTML root declaration) so the browser recognizes standards mode;
update the first-line declaration in the page HTML file accordingly.
- Line 26: The external anchor element (<a href="https://github.com/mochi-k18"
target="_blank">githubアカウント</a>) should include rel="noopener noreferrer" to
prevent tabnabbing; update the <a> tag in src/app/demo/mochi-k18/page.html by
adding the rel attribute alongside target="_blank" so the link becomes safe when
opened in a new tab.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 008c0808-210f-4cb8-9427-992a3745b30e
⛔ Files ignored due to path filters (1)
src/app/demo/mochi-k18/image.pngis excluded by!**/*.png
📒 Files selected for processing (3)
src/app/demo/mochi-k18/page.htmlsrc/app/demo/mochi-k18/style.csssrc/app/demo/page.tsx
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Contributor
|
ちょっとgithubアカウントのgだけに下線がかかっていないのが嫌だったので直しました |
Member
|
今日中のレビューを目指しています。 |
Contributor
|
とりあえずcssが反映されるようにしました。 |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
src/app/demo/mochi-k18/page.tsx (2)
11-11:⚠️ Potential issue | 🟡 MinorUse descriptive
alttext instead of"picture".Line 11 should describe the image subject for screen readers.
Proposed fix
- <Image src={profileImage} className={styles.icon} alt="picture" width={40} height={40} /> + <Image src={profileImage} className={styles.icon} alt="mochi-k18のプロフィール画像" width={40} height={40} />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/app/demo/mochi-k18/page.tsx` at line 11, The Image element rendering profileImage uses a non-descriptive alt ("picture"); update the alt on the Image JSX (the Image component that uses profileImage and styles.icon) to a meaningful description of the image content (e.g., "Profile photo of [subject]" or "Portrait of Mochi") so screen readers convey the subject rather than a generic term.
2-2:⚠️ Potential issue | 🟠 Major
BackButtonis still unused; either render it or remove the import.Line 2 triggers lint warnings, and the page currently misses quick navigation back to
/demo. If this page should match other demos, render it near the top.Proposed fix
export default function MochiK180DemoPage() { return ( <div className={styles.all}> + <BackButton path="/demo" title="デモサイト一覧へ戻る" /> <div className={styles.top}>Also applies to: 8-10
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/app/demo/mochi-k18/page.tsx` at line 2, The BackButton import in page.tsx is unused and causing lint warnings; either remove the import or render the BackButton component near the top of the page so this demo matches others and provides navigation back to /demo. Locate the BackButton symbol imported at the top of src/app/demo/mochi-k18/page.tsx and either delete that import line or insert the BackButton component into the page component's render output (near the top of the component's JSX/TSX) so it appears as the quick navigation control.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/app/demo/mochi-k18/page.tsx`:
- Line 12: The div uses a likely-typod CSS module key styles.ames which will be
undefined; open the component's CSS module that’s imported as styles, confirm
the intended exported class name (e.g., "ames", "frame", "wrapper" or similar),
and replace styles.ames in the JSX with the exact key from that CSS module (or
add the missing class to the CSS file). Also ensure you don't leave a bare
undefined by optionally wrapping with a safe fallback or using a classnames
helper if the class may be conditional.
---
Duplicate comments:
In `@src/app/demo/mochi-k18/page.tsx`:
- Line 11: The Image element rendering profileImage uses a non-descriptive alt
("picture"); update the alt on the Image JSX (the Image component that uses
profileImage and styles.icon) to a meaningful description of the image content
(e.g., "Profile photo of [subject]" or "Portrait of Mochi") so screen readers
convey the subject rather than a generic term.
- Line 2: The BackButton import in page.tsx is unused and causing lint warnings;
either remove the import or render the BackButton component near the top of the
page so this demo matches others and provides navigation back to /demo. Locate
the BackButton symbol imported at the top of src/app/demo/mochi-k18/page.tsx and
either delete that import line or insert the BackButton component into the page
component's render output (near the top of the component's JSX/TSX) so it
appears as the quick navigation control.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 39bbde21-1569-49e8-956d-709782a4cad0
📒 Files selected for processing (2)
src/app/demo/mochi-k18/page.tsxsrc/app/demo/mochi-k18/style.module.css
✅ Files skipped from review due to trivial changes (1)
- src/app/demo/mochi-k18/style.module.css
SakaYq4875
previously approved these changes
Mar 29, 2026
Member
どこですか？ |
Member
最新のデプロイされたものによると上のような結果となりました。
これは、このCSSで色を指定していないためだと思われ、bodyにcolor:black;を追加すればいいのではないかと思います。
|
Member
|
携帯しかないためその画面にはなりますがこうみると良いんですよね、 |
Member
確かにそうかもしれません。僕の持っているパソコンもスマホもダークモードにしているので。 |
SakaYq4875
requested changes
Mar 31, 2026
Member
SakaYq4875
left a comment
SakaYq4875
left a comment
There was a problem hiding this comment.
ダークモードの人もライトモードの人も同じ結果になるように調整
Co-authored-by: SakaYq4875 <yoshihito.s44110@gmail.com>
Shirym-min
approved these changes
Apr 3, 2026
SakaYq4875
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Changes Made
Testing
npm run devnpm run build)npm run lint)Screenshots (if applicable)
Checklist
Related Issues
Summary by CodeRabbit