Skip to content

Fix version download URL#18

Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
KSPModStewards:masterfrom
Sean-Kenneth-Doherty:codex/fix-version-download-url
Closed

Fix version download URL#18
Sean-Kenneth-Doherty wants to merge 1 commit into
KSPModStewards:masterfrom
Sean-Kenneth-Doherty:codex/fix-version-download-url

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty commented May 17, 2026

Summary

  • fix the generated KSP-AVC DOWNLOAD URL so it uses https://

Upstream check

  • read README, CONTRIBUTING, GPL-3.0 LICENSE, and GitHub workflows
  • checked open issues: none
  • checked open PRs: none

Validation

  • xmllint --noout src/HUDReplacer/HUDReplacer.csproj
  • git diff --check
  • verified the PR diff is limited to the missing colon in the generated DOWNLOAD URL

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty changed the title [codex] Fix generated version metadata Fix generated version metadata May 17, 2026
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/fix-version-download-url branch May 18, 2026 02:01
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty restored the codex/fix-version-download-url branch May 18, 2026 02:04
@Phantomical
Copy link
Copy Markdown
Collaborator

I will not be accepting changes to the compatibility ranges here, the existing ones in the version file are fine. The URL fix is useful though.

@Phantomical Phantomical marked this pull request as ready for review May 18, 2026 02:35
@Phantomical Phantomical marked this pull request as draft May 18, 2026 02:35
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty force-pushed the codex/fix-version-download-url branch from db9f125 to ff2abca Compare May 18, 2026 02:39
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty changed the title Fix generated version metadata Fix version download URL May 18, 2026
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Thanks, that makes sense. I revised this to keep only the DOWNLOAD URL fix and dropped the compatibility-range changes.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty marked this pull request as ready for review May 18, 2026 12:30
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/fix-version-download-url branch May 18, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants