Skip to content

Conversation

@lord41ph4
Copy link
Contributor

@lord41ph4 lord41ph4 commented May 13, 2025

I initially just wanted to fix the syntax highlighting issue. But somehow the project did not compile, so I took the chance to introduce the version catalogs, update some dependencies and do the fix for #86. (Fixes #86)

@lord41ph4 lord41ph4 changed the title [IDEA] Fix for #86 [IDEA] usage of version catalogs, kotlin version update and fix for #86 May 14, 2025
@valery-labuzhsky
Copy link
Contributor

Hey @lord41ph4,
Thanks for contributing. Looks good to me. Let me see if we could get it merged and released.

Hey @jim-hart,
Could we merge it? Also, could you please approve the workflow. "1 workflow awaiting approval". I think it's trying to run the tests.

@jim-hart
Copy link
Member

Hey @valery-labuzhsky, thanks for looking at this! The build failed here though.

I trust you if you say it's good to merge, but wanted to check first.

@valery-labuzhsky
Copy link
Contributor

valery-labuzhsky commented May 14, 2025

@lord41ph4 could you please fix the build?
Please tell me if you any advice is required, but it seems you are better at gradle than I do ;-)

@lord41ph4
Copy link
Contributor Author

Ok, let’s see. From the output I see that the build was running with Java 17. I think it's not the Gradle script itself but the runner configuration.

@lord41ph4
Copy link
Contributor Author

lord41ph4 commented May 14, 2025

@valery-labuzhsky I changed the Java Version in the workflow file, this should fix the build. Or do you want me to put the Java version in the Gradle script back to 17? - Would also be an option :D

@valery-labuzhsky
Copy link
Contributor

Thank you @lord41ph4, I think 21 is better :-) Let's wait until it's built.

@lord41ph4
Copy link
Contributor Author

lord41ph4 commented May 14, 2025

@valery-labuzhsky can you re-trigger the build for me? I think no job ran because the change was not in the IDEA folder.

@valery-labuzhsky
Copy link
Contributor

Unfortunately not. We need to wait for @jim-hart .

@jim-hart
Copy link
Member

@valery-labuzhsky @lord41ph4 build looks good now; are we good to merge?

@lord41ph4
Copy link
Contributor Author

Sure. I am done with my changes. :)

@jim-hart
Copy link
Member

Awesome, thanks @lord41ph4 and @valery-labuzhsky!

@jim-hart jim-hart merged commit e78bb45 into KSP-KOS:develop May 15, 2025
1 check passed
@jim-hart jim-hart self-requested a review May 15, 2025 11:00
@lord41ph4
Copy link
Contributor Author

Thanks for merging @jim-hart and @valery-labuzhsky for reviewing the changes. I am glad to contribute to this awesome tool.

@valery-labuzhsky
Copy link
Contributor

Released! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IDEA] Wrong syntax error highlighting when using _ in numbers or using annotation @CLOBBERBUILTINS

3 participants