Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the data ingestion layer to introduce a DataReader abstraction and selects a reader in the CLI based on the input file type, while also parameterizing the analysis window length used for FFT computations.
Changes:
- Introduce
DataReader+MatDataReaderscaffolding and update the pipeline entrypoint to use a reader instance. - Add CLI flags for
--data_typeand--output, and threadoutput_dirinto FFT plotting calls. - Replace the hard-coded
SAMPLES_PER_5_SECusage infft_analysiswithWINDOW_TIME_FRAME.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| data/src/main.py | Switches pipeline to use a DataReader instance and adds CLI args for reader selection and output directory. |
| data/src/data_reader.py | Adds abstract DataReader and a MatDataReader implementation (plus a CSV stub). |
| data/src/consts.py | Adds WINDOW_TIME_FRAME and a DATA_READERS mapping for CLI-driven reader selection. |
| data/src/fft_analysis.py | Uses WINDOW_TIME_FRAME-derived sample counts for FFT frequency axis and magnitude scaling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
change CSVReader to FIFReader OR keep CSVReader and add FIFReader |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.