refactor: rebase on sdk v1 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeg90
reviewed
Jan 15, 2024
lukeg90
reviewed
Jan 15, 2024
rflechtner
force-pushed
the
rf-sdk-1-alpha
branch
from
307d936 to
0f7a962
Compare
lukeg90
approved these changes
Jan 15, 2024
rflechtner
force-pushed
the
rf-sdk-1-alpha
branch
from
b261f52 to
a56682f
Compare
lukeg90
force-pushed
the
rf-sdk-1-alpha
branch
from
a56682f to
9e1dc1a
Compare
lukeg90
force-pushed
the
rf-sdk-1-alpha
branch
from
9e1dc1a to
1ec6850
Compare
Contributor
Author
|
any reason you closed this? @lukeg90 |
lukeg90
force-pushed
the
rf-sdk-1-alpha
branch
from
328f58f to
88e4870
Compare
Closed it by accident, sorry. But maybe it's better to make it a draft PR so it doesn't get merged by mistake? |
5 tasks
Member
Dudleyneedham
left a comment
Dudleyneedham
left a comment
There was a problem hiding this comment.
In general looking good.
Comments through out, but good progress.
…"holder" across messaging and quote modules
This reverts commit 7fcc0f2.
Member
|
LGTM. I would ask that raphael gives this one last look over and says if it can be merged. |
rflechtner
commented
Jun 11, 2025
Contributor
Author
rflechtner
left a comment
rflechtner
left a comment
There was a problem hiding this comment.
LGTM. The real test is going to be if a sporran using this library works with an existing app, and if an app using this library works with the existing sporran.
rflechtner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/3073
Adapts library to use sdk V1 instead. Introduces some changes to did config credential proofs in order to avoid dragging along more legacy proof suites.