fix: disable RPM post-install scripts for cross-compilation#23
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Our agent can fix these. Install it.
No application code in the PR — skipped Code Health checks.
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Problem
The
Generate Packagesjob in the release workflow fails when building the aarch64 RPM package on an x86_64 Ubuntu runner:This happens because
rpmbuildautomatically runsbrp-strip(binary stripping) as part of the%installphase. When cross-compiling, the native x86_64striptool cannot process aarch64 binaries.Fix
Add
%global __os_install_post %{nil}to the RPM spec template to disable all automatic post-install processing scripts, including:brp-strip(binary stripping)brp-compress(man page compression)brp-elfperms(ELF permission fixes)This is safe because:
cargo build --release)Result
Both x86_64 and aarch64 RPM packages build successfully on the x86_64 GitHub Actions runner.