Handling of query string in manifest media URLs #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Media URLs in the manifest can contain query string (called "auth" here), e.g. <media url="some?name=value" ...>. The fragment URLs then would be "...someSegX-FragY?name=value". Ideally, there should be a command-line switch for controlling this behavior, because I can easily imagine a situation where the segment and fragment numbers are passed via the query string, e.g. <media url="some?name=value&frag=" -> "...some?name=value&frag=SegX-FragY".
Fragment URLs or auth can expire with time. In case (1) a fragment verification fails, or (2) a fragment download fails with 403 Forbidden, we assume the fragment URL provided by the manifest or the user-provided "auth" string has expired and redownload the manifest or execute a user-provided script to get the fresh URLs/auth string(s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media URLs in the manifest can contain query string (called "auth" here), e.g. <media url="some?name=value" ...>. The fragment URLs then would be "...someSegX-FragY?name=value". Ideally, there should be a command-line switch for controlling this behavior, because I can easily imagine a situation where the segment and fragment numbers are passed via the query string, e.g. <media url="some?name=value&frag=" -> "...some?name=value&frag=SegX-FragY".