Skip to content

Conversation

@tokio-on-jupiter
Copy link
Contributor

Summary

  • Switches canary prerelease identifier from github.run_attempt to github.run_id
  • run_attempt resets to 1 for every new workflow run, causing version collisions when triggering multiple canary releases from the same PR
  • run_id is globally unique per workflow run, ensuring each /canary-release produces a distinct npm version

Context

Discovered while testing PR #1188 — repeated /canary-release triggers produced 17.2.2-canary-1188-1.0 each time, and lerna skipped publishing because the version already existed on npm.

Test plan

github.run_attempt resets to 1 for each new workflow run, causing
version collisions when triggering multiple canary releases from the
same PR. Switch to github.run_id which is globally unique per workflow
run, ensuring each canary publish produces a distinct version.
@tokio-on-jupiter tokio-on-jupiter requested a review from a team as a code owner January 28, 2026 20:52
Copilot AI review requested due to automatic review settings January 28, 2026 20:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a version collision issue in canary releases by switching from github.run_attempt to github.run_id for the prerelease identifier. The previous implementation reset to 1 for each workflow run, causing duplicate versions when multiple canary releases were triggered from the same PR.

Changes:

  • Updated the PRERELEASE_ID variable construction to use github.run_id instead of github.run_attempt

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tokio-on-jupiter tokio-on-jupiter merged commit 38af8e0 into main Jan 28, 2026
5 checks passed
@tokio-on-jupiter tokio-on-jupiter deleted the fix/canary-unique-version branch January 28, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants