feat: Add max slippage guard rails for strategy rebalance operations#673
Open
thebabalola wants to merge 1 commit into
Open
feat: Add max slippage guard rails for strategy rebalance operations#673thebabalola wants to merge 1 commit into
thebabalola wants to merge 1 commit into
Conversation
|
@thebabalola Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #561 by introducing max slippage guard rails and failure-safe behavior for strategy rebalance operations.
Changes Made:
rebalancefunction to theYieldVaultcontract (vault/src/lib.rs). This allows an atomic divest-and-invest flow between two distinct strategies.min_divest_valueto check against oracle manipulation or unexpected token deductions when withdrawing from thefrom_strategy.min_invest_valueto verify that the targetto_strategyaccrues at least the expected equivalent valuation during a deposit.rebalancesteps are fully atomic, any slippage threshold breach (either during withdrawal or deposit) instantly reverts the entire transaction.VaultErrorenum withSlippageExceeded = 15.This implementation mitigates the risk of value leakage when transitioning capital between connected yield strategies.