Skip to content

add an allow_reresolve kwarg on supported julia versions #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oxinabox merged 1 commit into from
Oct 27, 2025
Merged

add an allow_reresolve kwarg on supported julia versions #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/runner.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ end
notests::Vector{AbstractString},
logfilename::AbstractString;
coverage::Bool=false,
allow_reresolve::Bool=true,
julia_args::Union{Cmd, AbstractVector{<:AbstractString}}=``,
test_args::Union{Cmd, AbstractVector{<:AbstractString}}=``)

Expand All @@ -255,22 +256,32 @@ function test!(pkg::AbstractString,
notests::Vector{AbstractString},
logfilename::AbstractString;
coverage::Bool=false,
allow_reresolve::Union{Bool,Nothing}=nothing,
julia_args::Union{Cmd, AbstractVector{<:AbstractString}}=``,
test_args::Union{Cmd, AbstractVector{<:AbstractString}}=``)

# allow_reresolve is only supported in v1.9+, so we need to bail out if it's set to any
# non-default value on an earlier version.
if allow_reresolve !== nothing
VERSION < v"1.9" && throw(ArgumentError("allow_reresolve requires at least Julia 1.9"))
testenv_kwargs = (; allow_reresolve)
else
testenv_kwargs = (;)
end

# Copied from Pkg.test approach
julia_args = Cmd(julia_args)
test_args = Cmd(test_args)
ctx, pkgspec = try
TestEnv.ctx_and_pkgspec(pkg) # TODO: Don't use TestEnv internals
TestEnv.ctx_and_pkgspec(pkg) # TODO: Don't use TestEnv internals
catch err
if err isa TestEnv.TestEnvError
push!(nopkgs, pkg)
return
else
rethrow()
end
end
end
testfilepath = joinpath(TestEnv.get_test_dir(ctx, pkgspec), "runtests.jl")
check_testreports_compatability(ctx, pkgspec, testfilepath)

Expand All @@ -279,7 +290,7 @@ function test!(pkg::AbstractString,
else
runner_code = gen_runner_code(testfilepath, logfilename, test_args)
cmd = gen_command(runner_code, julia_args, coverage)
TestEnv.activate(pkg) do
TestEnv.activate(pkg; testenv_kwargs...) do
runtests!(errs, pkg, cmd, logfilename)
end
end
Expand Down
Loading