Skip to content

Add Aqua tests#115

Draft
omus wants to merge 1 commit intomasterfrom
cv/aqua
Draft

Add Aqua tests#115
omus wants to merge 1 commit intomasterfrom
cv/aqua

Conversation

@omus
Copy link
Member

@omus omus commented May 22, 2024

No description provided.

@omus
Copy link
Member Author

omus commented May 22, 2024

Julia 1.10 runs into this problem:

TestReports compatibility: Test Failed at /home/runner/work/TestReports.jl/TestReports.jl/test/utils.jl:132
  Expression: TestReports.test(pkg)
    Expected: TestReports.PkgTestError
      Thrown: MethodError

The MethodError is this:

TestReports compatibility: Error During Test at /Users/cvogt/.julia/dev/TestReports/test/runnerinternals.jl:33
  Got exception outside of a @test
  MethodError: no method matching compatible(::VersionNumber, ::Nothing)

  Closest candidates are:
    compatible(::VersionNumber, ::VersionNumber)
     @ TestReports ~/.julia/dev/TestReports/src/compat_check.jl:9
    compatible(::VersionNumber, ::String)
     @ TestReports ~/.julia/dev/TestReports/src/compat_check.jl:10
    compatible(::VersionNumber, ::Pkg.Versions.VersionSpec)
     @ TestReports ~/.julia/dev/TestReports/src/compat_check.jl:11
    ...

  Stacktrace:
    [1] check_manifest(manifest::Pkg.Types.Manifest, pkg::String, loc::String, dep_to_check::Pkg.Types.PackageEntry)
      @ TestReports ~/.julia/dev/TestReports/src/compat_check.jl:113
    [2] check_env(env::Pkg.Types.EnvCache, pkg::String, loc::String, deps_to_check::Vector{Pkg.Types.PackageEntry})
      @ TestReports ~/.julia/dev/TestReports/src/compat_check.jl:131
    [3] check_testreports_compatability(ctx::Pkg.Types.Context, pkgspec::Pkg.Types.PackageSpec, testfilepath::String)
      @ TestReports ~/.julia/dev/TestReports/src/compat_check.jl:216
    [4] test!(pkg::String, errs::Vector{AbstractString}, nopkgs::Vector{AbstractString}, notests::Vector{AbstractString}, logfilename::String; coverage::Bool, julia_args::Cmd, test_args::Cmd)
      @ TestReports ~/.julia/dev/TestReports/src/runner.jl:374
    [5] test!
      @ ~/.julia/dev/TestReports/src/runner.jl:352 [inlined]
    [6] test(pkgs::Vector{String}; logfilename::Vector{String}, logfilepath::String, kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
      @ TestReports ~/.julia/dev/TestReports/src/runner.jl:468
    [7] test
      @ ~/.julia/dev/TestReports/src/runner.jl:452 [inlined]
    [8] #test#25
      @ ~/.julia/dev/TestReports/src/runner.jl:451 [inlined]
    [9] test
      @ ~/.julia/dev/TestReports/src/runner.jl:451 [inlined]
   [10] (::var"#13#14"{String})(tmp::String)
      @ Main ~/.julia/dev/TestReports/test/utils.jl:133
   [11] (::var"#5#6"{Bool, Bool, var"#13#14"{String}, String})()
      @ Main ~/.julia/dev/TestReports/test/utils.jl:82
   [12] withenv(::var"#5#6"{Bool, Bool, var"#13#14"{String}, String}, ::Pair{String, Nothing}, ::Vararg{Pair{String, Nothing}})
      @ Base ./env.jl:197
   [13] temp_pkg_dir(fn::var"#13#14"{String}; rm::Bool, add_testresports_env::Bool)
      @ Main ~/.julia/dev/TestReports/test/utils.jl:74
   [14] temp_pkg_dir
      @ ~/.julia/dev/TestReports/test/utils.jl:65 [inlined]
   [15] test_package_expected_fail(pkg::String)
      @ Main ~/.julia/dev/TestReports/test/utils.jl:130
   [16] macro expansion
      @ ~/.julia/dev/TestReports/test/runnerinternals.jl:62 [inlined]
   [17] macro expansion
...

Somehow adding Aqua in as a dependency seems to be causing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant