Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 31 31
Lines 819 819
=======================================
Hits 622 622
Misses 197 197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oxinabox
reviewed
Dec 14, 2025
Comment on lines
+58
to
+59
| # To reduce the number of CI jobs, we test Linux 64-bit against all Julia versions (see above), | ||
| # but for other platforms: |
Member
There was a problem hiding this comment.
Suggested change
| # To reduce the number of CI jobs, we test Linux 64-bit against all Julia versions (see above), | |
| # but for other platforms: | |
| # We test Linux 64-bit against all Julia versions (see above), | |
| # but for other platforms we test less (see below). Thus reducing number of CI jobs |
oxinabox
reviewed
Dec 14, 2025
Member
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
I am not sure it's worth having CI on anything except linux if it doesn't test all versions.
Because a change that only effects one version could be made in any PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, we have 64 CI jobs, which is a lot.
This PR reduces the number of CI jobs:
After this PR, we have 23 CI jobs.