Skip to content

Replace Base.walkdir with variation that skips hidden directories #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickrobinson251 merged 3 commits into from
Jan 20, 2026
Merged

Replace Base.walkdir with variation that skips hidden directories #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a10661d
Replace `Base.walkdir` with variation that skips hidden directories
nickrobinson251 Jan 15, 2026
f15e194
Update src/ReTestItems.jl
nickrobinson251 Jan 16, 2026
2251a82
Bump version
nickrobinson251 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ReTestItems"
uuid = "817f1d60-ba6b-4fd5-9520-3cf149f6a823"
version = "1.35.0"
version = "1.35.1"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
20 changes: 16 additions & 4 deletions src/ReTestItems.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,19 @@ function nestedrelpath(path::T, startdir::AbstractString) where {T <: AbstractSt
end
end

# Like `Base.walkdir` but does not descend into hidden directories (those starting with '.')
function _walkdir(root)
return Channel{Tuple{String, Vector{String}, Vector{String}}}() do ch
for (dir, dirs, files) in Base.walkdir(root; topdown=true)
# Filter out hidden directories to prevent descending into them.
# Modifying `dirs` in-place works because walkdir uses it to determine
# which subdirectories to visit next (when topdown=true, the default).
filter!(d -> !startswith(d, '.'), dirs)
put!(ch, (dir, dirs, files))
end
end
end

# is `dir` the root of a subproject inside the current project?
function _is_subproject(dir, current_projectfile)
projectfile = _project_file(dir)
Expand Down Expand Up @@ -825,8 +838,8 @@ function include_testfiles!(project_name, projectfile, paths, ti_filter::TestIte
end
return setups
end
hidden_re = r"\.\w"
@sync for (root, d, files) in Base.walkdir(project_root)
# Use _walkdir to skip hidden directories
@sync for (root, d, files) in _walkdir(project_root)
if subproject_root !== nothing && startswith(root, subproject_root)
@debugv 1 "Skipping files in `$root` in subproject `$subproject_root`"
continue
Expand All @@ -835,12 +848,11 @@ function include_testfiles!(project_name, projectfile, paths, ti_filter::TestIte
continue
end
rpath = nestedrelpath(root, project_root)
startswith(rpath, hidden_re) && continue # skip hidden directories
dir_node = DirNode(rpath; report, verbose=verbose_results)
dir_nodes[rpath] = dir_node
push!(get(dir_nodes, dirname(rpath), root_node), dir_node)
for file in files
startswith(file, hidden_re) && continue # skip hidden files
startswith(file, '.') && continue # skip hidden files
filepath = joinpath(root, file)
# We filter here, rather than the testitem level, to make sure we don't
# `include` a file that isn't supposed to be a test-file at all, e.g. its
Expand Down
Loading