[WIP] Try to filter test items without constructing the AST#226
Draft
Drvi wants to merge 6 commits intotd-include-tasksfrom
Draft
[WIP] Try to filter test items without constructing the AST#226Drvi wants to merge 6 commits intotd-include-tasksfrom
Drvi wants to merge 6 commits intotd-include-tasksfrom
Conversation
Drvi
force-pushed
the
td-filter-on-tokens
branch
from
eef17f7 to
456f1d1
Compare
| Random = "1" | ||
| Serialization = "1" | ||
| Sockets = "1" | ||
| StringViews = "1" |
Member
There was a problem hiding this comment.
we can't (don't want) any non-stdlib deps... how much benefit does StringViews give us? Our options are (i think): drop it, reimplement a minimal version, vendor it
Collaborator
Author
There was a problem hiding this comment.
The only thing this gives is the ability to run regexes against a view of a Vector{UInt8} (and comparing them to Strings, but that is easy to do manually)
Project.toml
Outdated
|
|
||
| [compat] | ||
| Dates = "1" | ||
| JuliaSyntax = "0.4, 1" |
Member
There was a problem hiding this comment.
this we'd probably have to vendor
Collaborator
Author
There was a problem hiding this comment.
How about we go from using JuliaSyntax to using Base.JuliaSyntax 😈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also means we're not validating every test item on every run -- only those that match the name will be evaluated.