Attempt to introduce graceful close from workers back to coordinator#152
Closed
NHDaly wants to merge 3 commits intonpr-gentle-close-workersfrom
Closed
Attempt to introduce graceful close from workers back to coordinator#152NHDaly wants to merge 3 commits intonpr-gentle-close-workersfrom
NHDaly wants to merge 3 commits intonpr-gentle-close-workersfrom
Conversation
Member
Author
|
@nickrobinson251 but this doesn't seem to be quite right either. With this change, now the tests are hanging; i'm not yet sure why. ERROR: LoadError: InterruptException:
Stacktrace:
[1] try_yieldto(undo::typeof(Base.ensure_rescheduled))
@ Base ./task.jl:931
[2] wait()
@ Base ./task.jl:995
[3] wait(c::Base.GenericCondition{Base.Threads.SpinLock}; first::Bool)
@ Base ./condition.jl:130
[4] wait
@ ./condition.jl:125 [inlined]
[5] _wait(t::Task)
@ Base ./task.jl:310
[6] wait
@ ./task.jl:350 [inlined]
[7] fetch
@ ./task.jl:372 [inlined]
[8] wait(w::Worker)
@ ReTestItems.Workers ~/.julia/dev/ReTestItems/src/workers.jl:128
[9] close(w::Worker, from::Symbol)
@ ReTestItems.Workers ~/.julia/dev/ReTestItems/src/workers.jl:123
[10] close(w::Worker)
@ ReTestItems.Workers ~/.julia/dev/ReTestItems/src/workers.jl:115
[11] macro expansion
@ ~/.julia/dev/ReTestItems/test/workers.jl:18 [inlined]
[12] macro expansion
@ ~/builds/julia-RAI/usr/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]not sure why, but gotta run now. 👋 |
a463377 to
aefc3e6
Compare
…se to its shutdown signal. But encountering a bug: JuliaLang/julia#54145
aefc3e6 to
2a8768b
Compare
Member
Author
|
Closing in favor of #155. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges into #151.