Skip to content

Try not using gensym for testsetup module names#149

Draft
nickrobinson251 wants to merge 1 commit intomainfrom
npr-dont-gensym-testsetup
Draft

Try not using gensym for testsetup module names#149
nickrobinson251 wants to merge 1 commit intomainfrom
npr-dont-gensym-testsetup

Conversation

@nickrobinson251
Copy link
Member

current using @testsetup module means error messages/tracebacks that refer to it get really ugly names like
Main.var"##FDSetup#298", eg:

    [2] fd_test(::Type, ::Vararg{Any}; verbose::Bool)
      @ Main.var"##FDSetup#298" ~/base-fds/test/base-fd-tests.jl:259

@rntz
Copy link
Contributor

rntz commented Mar 14, 2024

Any idea what went wrong with the tests here

@rntz
Copy link
Contributor

rntz commented Mar 14, 2024

looks like the tests that failed were precisely the ones testing log capture?

@Drvi
Copy link
Collaborator

Drvi commented Mar 14, 2024

Looking the CI logs, IIUC, a new warning showed up WARNING: replacing module LoggingTestSetup, breaking some of the log capture tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants