Conversation
Cover parse_args, filter_tests!, extract_flag!, find_tests edge cases, get_max_worker_rss, test_exe, non-verbose mode, quickfail, positional filtering, addworkers, multi-job parallelism, worker RSS recycling, mixed pass/fail, and empty test suite. Co-authored-by: Claude <noreply@anthropic.com> Made-with: Cursor
For this test to be really useful, we'd need to test that `pass-test` isn't run at all, but the exact order of execution of the tests isn't determistic at the moment, by design (unless we passed another argument with the exact desidered order of the tests), so this test isn't much useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning to do some refactoring, so I asked my friendly assistant to add more tests (both unit and integration) for this package. I reviewed all the changes, and for example I removed a pointless test.
Probably some of these tests could still be improved (I'm not super happy about the RSS memory test just checking
get_max_worker_rss() > 0for the default case, but we'd basically have to hardcode the default value, which depends on various conditions, and that seems a bit meh, but I guess at least checking that the result is strictly positive is better than nothing), but they looked overall sensible to me.