Open
Conversation
stevengj
reviewed
Apr 2, 2026
Member
|
LGTM. Out of curiosity, what is the motivation to replace the NSString functions? |
Author
|
NSString functions are in the part of Foundation that depend on FoundationInternationalization, increasing the size of a statically linked (everything, including libc) Linux binary by ~50MB (mostly ICU data). The pitch to add these functions to the stdlib has been inactive for a while and still needs work based on the GH comments: https://forums.swift.org/t/pitch-unicode-normalization/73240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.