Make coeftable(::MatrixTerm) always return Vector{String} #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
|
I'm willing to approve if you review my #301. ;-) |
nalimilan
approved these changes
Dec 22, 2025
andreasnoack
added a commit
that referenced
this pull request
Jan 4, 2026
* Update to Aqua@0.8
* Test on pre instead of nightly
* Update runtests.jl
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
* Make coeftable(::MatrixTerm) always return Vector{String} (#334)
* Adjust test for #185 to not rely on old reduce(vcat, ...) behavior for single element collections (#335)
* Adjust test for #185 to not rely on old reduce(vcat, ...) behavior for single element collections
* Run CI on all PRs
---------
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112. @kleinschmidt you marked it as breaking, but it seems a bit odd if anybody is relying on this. See JuliaStats/GLM.jl#621