Review of matprod_dest behaviour with sparse factors#693
Open
Review of matprod_dest behaviour with sparse factors#693
matprod_dest behaviour with sparse factors#693Conversation
Member
Author
|
This obviously changes return types and is therefore not for backport (except for v1.13?). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This intends to fix the unexpected matrix return type behaviour observed in #685 (comment). The goal is determine the return type by the (potentially) non-sparse factor. For
BandedMatrixtypes, however, the return type should be sparse, since these are themselves "sparse".I can't seem to be able to run tests, but it seems that this yields a major speed-up in multiplication, and so fixes #685 (to be confirmed).