Skip to content

make \ type stable#684

Open
araujoms wants to merge 2 commits intomainfrom
araujoms/typestability
Open

make \ type stable#684
araujoms wants to merge 2 commits intomainfrom
araujoms/typestability

Conversation

@araujoms
Copy link
Copy Markdown
Contributor

Closes #111

Since UMFPACK is not going to add support for Float32 anytime soon I think the only solution is to manually convert back. Also, since the code for dealing with the output of lu is not generic, there is no point in converting back the decomposition itself, so I'm just converting the result of lu(A) \ b to the appropriate type.

I also did the analogous change to achieve type stability with Float16. There's also nothing that can be done about CHOLMOD, but for SPQR the situation is better: the code around it is generic, so I just converted back qr(A) itself.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.31%. Comparing base (2b32b60) to head (b5450f8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
+ Coverage   84.28%   84.31%   +0.03%     
==========================================
  Files          13       13              
  Lines        9340     9347       +7     
==========================================
+ Hits         7872     7881       +9     
+ Misses       1468     1466       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

\ promotes Float32 solves to Float64

1 participant