Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
==========================================
+ Coverage 84.28% 84.31% +0.03%
==========================================
Files 13 13
Lines 9340 9347 +7
==========================================
+ Hits 7872 7881 +9
+ Misses 1468 1466 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111
Since UMFPACK is not going to add support for
Float32anytime soon I think the only solution is to manually convert back. Also, since the code for dealing with the output ofluis not generic, there is no point in converting back the decomposition itself, so I'm just converting the result oflu(A) \ bto the appropriate type.I also did the analogous change to achieve type stability with
Float16. There's also nothing that can be done about CHOLMOD, but for SPQR the situation is better: the code around it is generic, so I just converted backqr(A)itself.