Skip to content

Apply hdr_override to invariant columns#204

Open
arnavk23 wants to merge 6 commits into
JuliaSmoothOptimizers:mainfrom
arnavk23:Hdr
Open

Apply hdr_override to invariant columns#204
arnavk23 wants to merge 6 commits into
JuliaSmoothOptimizers:mainfrom
arnavk23:Hdr

Conversation

@arnavk23
Copy link
Copy Markdown
Contributor

@arnavk23 arnavk23 commented Apr 9, 2026

Fixes #22
@dpo @tmigot

arnavk23 added 2 commits April 9, 2026 10:52
Added functionality to apply header overrides to invariant columns and rename them accordingly.
Copilot AI review requested due to automatic review settings April 9, 2026 05:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates join(stats, ...) so hdr_override is applied to invariant columns (e.g., :name) and adds a test to validate the renamed invariant column is present in the joined DataFrame.

Changes:

  • Apply hdr_override to the invariant-columns DataFrame extracted from the first solver.
  • Update invariant column symbols to match overridden names.
  • Add a test asserting the overridden invariant column name exists in df_joined.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/join.jl Renames invariant columns according to hdr_override before joining per-solver columns.
test/test-tables.jl Extends the join-table test to override :name and asserts :Name exists.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/join.jl Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/join.jl:33

  • join_key is introduced, but the function still hardcodes :id in the validation (all(:id in propertynames(df) ...)) and later in the join operation. To avoid drift and make the intent clear, use join_key consistently for the presence check and the innerjoin(...; on=join_key) call (and any other :id literals in this function).
  join_key = :id
  length(cols) == 0 && error("cols can't be empty")
  if !all(:id in propertynames(df) for (s, df) in stats)
    error("Missing column :id in some DataFrame")
  elseif !all(setdiff(cols, propertynames(df)) == [] for (s, df) in stats)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.37%. Comparing base (4c0fcd2) to head (c208776).
⚠️ Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
src/join.jl 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   76.71%   86.37%   +9.66%     
==========================================
  Files          12       10       -2     
  Lines         292      301       +9     
==========================================
+ Hits          224      260      +36     
+ Misses         68       41      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/join.jl Outdated
Comment thread src/join.jl Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread src/join.jl
Comment thread test/test-tables.jl
arnavk23 and others added 2 commits May 12, 2026 20:24
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@arnavk23
Copy link
Copy Markdown
Contributor Author

@tmigot Added the copilot suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hdr_override in join doesn't affect invariant_cols.

3 participants