Apply hdr_override to invariant columns#204
Conversation
Added functionality to apply header overrides to invariant columns and rename them accordingly.
There was a problem hiding this comment.
Pull request overview
Updates join(stats, ...) so hdr_override is applied to invariant columns (e.g., :name) and adds a test to validate the renamed invariant column is present in the joined DataFrame.
Changes:
- Apply
hdr_overrideto the invariant-columns DataFrame extracted from the first solver. - Update invariant column symbols to match overridden names.
- Add a test asserting the overridden invariant column name exists in
df_joined.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/join.jl |
Renames invariant columns according to hdr_override before joining per-solver columns. |
test/test-tables.jl |
Extends the join-table test to override :name and asserts :Name exists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/join.jl:33
join_keyis introduced, but the function still hardcodes:idin the validation (all(:id in propertynames(df) ...)) and later in the join operation. To avoid drift and make the intent clear, usejoin_keyconsistently for the presence check and theinnerjoin(...; on=join_key)call (and any other:idliterals in this function).
join_key = :id
length(cols) == 0 && error("cols can't be empty")
if !all(:id in propertynames(df) for (s, df) in stats)
error("Missing column :id in some DataFrame")
elseif !all(setdiff(cols, propertynames(df)) == [] for (s, df) in stats)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 76.71% 86.37% +9.66%
==========================================
Files 12 10 -2
Lines 292 301 +9
==========================================
+ Hits 224 260 +36
+ Misses 68 41 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@tmigot Added the copilot suggestions. |
Fixes #22
@dpo @tmigot