Open
Conversation
Member
Author
|
The test failure is due to #128. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an undefined value error in the test_zero_allocations function for AbstractNLSModel by providing a default value for the linear_api parameter.
- Replaces undefined
linear_apireference with explicitfalsedefault value
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| end | ||
|
|
||
| function test_zero_allocations(nlp::AbstractNLSModel; linear_api = linear_api, kwargs...) | ||
| function test_zero_allocations(nlp::AbstractNLSModel; linear_api = false, kwargs...) |
There was a problem hiding this comment.
The default value false for linear_api may not be consistent with the behavior expected by callers or with other similar functions. Consider verifying that false is the appropriate default value by checking how this parameter is used in the function body and comparing with similar functions in the codebase.
Suggested change
| function test_zero_allocations(nlp::AbstractNLSModel; linear_api = false, kwargs...) | |
| function test_zero_allocations(nlp::AbstractNLSModel; linear_api = true, kwargs...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.