Skip to content

redo HomotopyDensityDFG, creep change serialization approach#1231

Draft
dehann wants to merge 4 commits intodevelopfrom
26Q2/refac/amp15_alternate
Draft

redo HomotopyDensityDFG, creep change serialization approach#1231
dehann wants to merge 4 commits intodevelopfrom
26Q2/refac/amp15_alternate

Conversation

@dehann
Copy link
Copy Markdown
Member

@dehann dehann commented May 7, 2026

Alternative redo of -- creep change implementation of serialization:

At the time of writing, 1230 is good enough for AMP v0.15.0-alpha tests to pass. This redo is easiest path to make sure DFG serialization also works for new HomotopyDensityDFG (replaces StoredHomotopyBelief). Some detail on abstracts in new HomotopyRepr

@dehann dehann added this to the v0.29.0 milestone May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 67.16418% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.28%. Comparing base (9cb713e) to head (07e8cc3).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/Deprecated.jl 45.45% 18 Missing ⚠️
src/services/compare.jl 50.00% 3 Missing ⚠️
src/entities/HomotopyDensity.jl 96.15% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1231      +/-   ##
===========================================
- Coverage    80.85%   80.28%   -0.58%     
===========================================
  Files           49       50       +1     
  Lines         2648     2693      +45     
===========================================
+ Hits          2141     2162      +21     
- Misses         507      531      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Johannes Terblanche <Affie@users.noreply.github.com>
@dehann dehann linked an issue May 7, 2026 that may be closed by this pull request
@dehann dehann removed their assignment May 7, 2026
@dehann dehann marked this pull request as ready for review May 8, 2026 07:08
@dehann
Copy link
Copy Markdown
Member Author

dehann commented May 8, 2026

Hi @Affie , i was having some trouble with json ignore -- i'll try a bit more and will post here if i learn anything more in the next 30 mins or so. Think this is at good enough a point for you to take over on this PR please

formatting

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dehann
Copy link
Copy Markdown
Member Author

dehann commented May 8, 2026

shoot, i messed up -- still a few clean ups that i missed (i blame lack of sleep)

@dehann dehann marked this pull request as draft May 8, 2026 19:08
@dehann dehann self-assigned this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid the Gaussian-only road

2 participants