Skip to content

Conversation

@thimotedupuch
Copy link
Collaborator

This is my first contribution to this project.

  • I started by performing a global formatting with Runic.jl, on a separate commit so reviewers should be able to see the diffs correctly.

  • I added the missing docs for intersectLineToPlane3D

  • I implemented the CPU version of radialDistortion!

@Affie
Copy link
Member

Affie commented Nov 20, 2025

Hi @thimotedupuch, thanks for the contribution. I'm not familiar enough with that part of the code to help review. But I do see the tests are failing because of code that moved from Manifolds.jl to LieGroups.jl. Give me a few days and I'll upgrade to LieGroups.jl.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 57.57576% with 56 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@8f0cda2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/services/CameraServices.jl 48.07% 27 Missing ⚠️
src/services/Utils.jl 32.25% 21 Missing ⚠️
src/Deprecated.jl 70.37% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #34   +/-   ##
==========================================
  Coverage           ?   60.60%           
==========================================
  Files              ?        7           
  Lines              ?      165           
  Branches           ?        0           
==========================================
  Hits               ?      100           
  Misses             ?       65           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Affie
Copy link
Member

Affie commented Dec 4, 2025

Hi @thimotedupuch. I fixed the LieGroups.jl issue and also fixed a config issue with code coverage.
Would you mind adding a test for radialDistortion!?

@thimotedupuch
Copy link
Collaborator Author

So, this took longer than expected: I took the time to review the repo as a whole and noticed many inconsistencies. You can close this PR or merge it if you prefer. I plan to initiate more significant changes to the code. I intend to update the dependencies, remove some, and simplify many parts of the codebase.
Most importantly, we need to clarify which other packages interface with this one.
In any case, I’ve rewritten the radialDistortion! function and added a basic test for it.

@Affie Affie merged commit 1c1da79 into JuliaRobotics:develop Dec 15, 2025
2 of 3 checks passed
@Affie
Copy link
Member

Affie commented Dec 15, 2025

Contributions to CameraModels.jl are very welcome, and we would especially appreciate someone willing to take on a more dedicated maintenance role. Please note that the package is used by RoME.jl and Caesar.jl, so changes should follow semantic versioning with clear deprecations where applicable. Beyond that, feel free to move things forward.

@thimotedupuch thimotedupuch deleted the small_fixes branch December 15, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants