-
Notifications
You must be signed in to change notification settings - Fork 1
Small changes #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small changes #34
Conversation
|
Hi @thimotedupuch, thanks for the contribution. I'm not familiar enough with that part of the code to help review. But I do see the tests are failing because of code that moved from Manifolds.jl to LieGroups.jl. Give me a few days and I'll upgrade to LieGroups.jl. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #34 +/- ##
==========================================
Coverage ? 60.60%
==========================================
Files ? 7
Lines ? 165
Branches ? 0
==========================================
Hits ? 100
Misses ? 65
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @thimotedupuch. I fixed the LieGroups.jl issue and also fixed a config issue with code coverage. |
|
So, this took longer than expected: I took the time to review the repo as a whole and noticed many inconsistencies. You can close this PR or merge it if you prefer. I plan to initiate more significant changes to the code. I intend to update the dependencies, remove some, and simplify many parts of the codebase. |
|
Contributions to CameraModels.jl are very welcome, and we would especially appreciate someone willing to take on a more dedicated maintenance role. Please note that the package is used by RoME.jl and Caesar.jl, so changes should follow semantic versioning with clear deprecations where applicable. Beyond that, feel free to move things forward. |
This is my first contribution to this project.
I started by performing a global formatting with
Runic.jl, on a separate commit so reviewers should be able to see the diffs correctly.I added the missing docs for
intersectLineToPlane3DI implemented the CPU version of
radialDistortion!