Skip to content

Conversation

@arnavk23
Copy link
Collaborator

@arnavk23 arnavk23 commented Jan 9, 2026

  • Extract release branch from registry PR body (Registrator [branch=]) and prioritize it over config/default when creating releases.
  • Thread version through release-branch helpers so per-version branch selection works.
  • Add tests for branch parsing/priority and update release tests to avoid network calls.
  • Fixes Look up release branch in commit comment #200

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances TagBot to honor the branch specification from Registrator when creating releases. The implementation extracts the branch information from the registry PR body and prioritizes it over the configured or default branch.

Key changes:

  • Converts _release_branch from a property to a method that accepts a version parameter, enabling per-version branch selection
  • Adds _branch_from_registry_pr() method to parse branch information from registry PR body using regex
  • Updates all call sites to thread version information through the release-branch helpers

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tagbot/action/repo.py Implements branch extraction from registry PR body, converts _release_branch to version-aware method, and updates all dependent methods
test/action/test_repo.py Adds comprehensive tests for branch parsing logic and updates existing tests to pass version parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

arnavk23 and others added 3 commits January 10, 2026 04:08
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@arnavk23
Copy link
Collaborator Author

@IanButterworth whenever you are free, please take a look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Look up release branch in commit comment

1 participant