Skip to content

More beautiful display of :unknown #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kolaru wants to merge 2 commits into
base: master
Choose a base branch
from
Open

More beautiful display of :unknown #247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e83aa4
Change display in :compact IOContext
Kolaru May 13, 2026
48f0a82
Use fancy connectors to group the information
Kolaru May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/root_object.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,23 +57,22 @@ isunique(rt::Root{T}) where {T} = (rt.status == :unique)

function show(io::IO, rt::Root)
print(io, "Root($(rt.region), :$(rt.status))")
end

function show(io::IO, ::MIME"text/plain", rt::Root)
show(io, rt)
if rt.status == :unknown
if !get(io, :compact, false) && rt.status == :unknown
connector = isnothing(rt.error) ? "└" : "├"
if rt.convergence == :tolerance
print(io, "\n Not converged: region size smaller than the tolerance")
print(io, "\n $connector Not converged: region size smaller than the tolerance")
elseif rt.convergence == :max_iterartion
print(io, "\n Not converged: reached maximal number of iterations")
print(io, "\n $connector Not converged: reached maximal number of iterations")
elseif rt.convergence == :none
print(io, "\n Not converged: the root is still being processed")
print(io, "\n $connector Not converged: the root is still being processed")
else
print(io, "\n Not converged: unknown reason $(rt.convergence)")
print(io, "\n $connector Not converged: unknown reason $(rt.convergence)")
end

if !isnothing(rt.error)
print(io, "\n Warning: error encountered during computation (use showerror(root.error) to see the whole stacktrace)\n ")
print(io, "\n ├ Warning: error encountered during computation (use showerror(root.error) to see the whole stacktrace)\n └ ")
showerror(io, rt.error[1])
end
end
Expand Down
Loading