Small fix to magic number error printing#53
Merged
giordano merged 1 commit intoJuliaIO:masterfrom Aug 12, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 68.09% 70.27% +2.18%
==========================================
Files 46 46
Lines 1332 1386 +54
==========================================
+ Hits 907 974 +67
+ Misses 425 412 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a42434e to
660737b
Compare
660737b to
9ab9cbf
Compare
giordano
approved these changes
Aug 12, 2025
Comment on lines
-52
to
-53
| Magic Number 0x$(join(string.(magic, base=16),"")) does not match expected PE | ||
| magic number 0x$(join("", string.(PE_magic, base=16))) |
Member
There was a problem hiding this comment.
How....did this ever work 😕 I guess it never did. Also in v0.6, when this line
ObjectFile.jl/src/COFF/COFFHandle.jl
Line 53 in 058bdba
julia> join("", hex.(UInt8['P','E','\0','\0']))
""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
after: