Merged
Conversation
This returns the offset into the file that the symbol refers to. This also checks in a version of libjulia and uses the dep_libs string as a test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 69.00% 70.05% +1.05%
==========================================
Files 46 46
Lines 1371 1386 +15
==========================================
+ Hits 946 971 +25
+ Misses 425 415 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
topolarity
reviewed
Jul 9, 2025
staticfloat
approved these changes
Jul 10, 2025
| function isundef(sym::MachOSymtabEntry) | ||
| return (symbol_type(sym) == N_UNDF) || | ||
| (isglobal(sym) && symbol_section(sym) == NO_SECT) | ||
| (isglobal(sym) && sym.n_sect == NO_SECT) |
Collaborator
There was a problem hiding this comment.
Reading the comments below, should this be checking for 0 instead of NO_SECT?
Contributor
Author
There was a problem hiding this comment.
I think that was me being inconsistent. NO_SECT is just 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This returns the offset into the file that the symbol refers to.
This also checks in a version of libjulia and uses the dep_libs string as a test.