Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 68.09% 69.00% +0.90%
==========================================
Files 46 46
Lines 1332 1371 +39
==========================================
+ Hits 907 946 +39
Misses 425 425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Nightly won't work at the moment due to JuliaLang/julia#57699 |
c9463db to
72121f6
Compare
Contributor
|
Can you add some tests for the new functionality? 🙂 |
72121f6 to
4ef64df
Compare
`ELFVersionNeededData` should produce a list of `ELFVersionNeededEntry` just as `ELFVersionData` produces a list of `ELFVersionEntry`. Export both and add docs + tests.
4abb742 to
c357a27
Compare
topolarity
approved these changes
Mar 14, 2025
Contributor
topolarity
left a comment
There was a problem hiding this comment.
Nice changes! Easy to read, and test coverage looks good.
Thanks much @mlechu !
Contributor
|
@giordano or @staticfloat , is it possible to get a quick review here? Changes look complete to me, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used ObjectFile to write a script to patch versions in ELF files and decided some parts of it might belong here.
ELFVersionDatanot working if it doesn't find a.gnu.version_dsection:ELFVersionNeededData, a similar function for version requirements (.gnu.version_r)