Skip to content

Add LineString constructor for AbstractVector #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
asinghvi17 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add LineString constructor for AbstractVector #275

asinghvi17 wants to merge 1 commit into from

Conversation

@asinghvi17
Copy link
Contributor

@asinghvi17 asinghvi17 commented Jan 17, 2026

Fixes GI.convert failing when geometry is backed by StaticArrays.

GI.convert(GB, GI.LineString(SA[(1., 2.), (3., 4.)]))
# Before: MethodError (LineString doesn't accept SizedVector)
# After: Works correctly

🤖 Generated with Claude Code

@asinghvi17 asinghvi17 force-pushed the as/fix-gi-convert-staticarray branch from 1351bce to 83a0844 Compare January 17, 2026 14:00
@asinghvi17 @claude
Add LineString constructor for AbstractVector
867d298 
Fixes GI.convert failing when geometry is backed by StaticArrays.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@asinghvi17 asinghvi17 force-pushed the as/fix-gi-convert-staticarray branch from 83a0844 to 867d298 Compare January 17, 2026 14:07
@asinghvi17 asinghvi17 closed this Jan 20, 2026
@asinghvi17 asinghvi17 reopened this Jan 20, 2026
@asinghvi17 asinghvi17 mentioned this pull request Jan 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonDanisch SimonDanisch Awaiting requested review from SimonDanisch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asinghvi17