[WIP] Add a Tables.jl extension for FeatureCollection and Feature#156
Draft
asinghvi17 wants to merge 3 commits intomainfrom
Draft
[WIP] Add a Tables.jl extension for FeatureCollection and Feature#156asinghvi17 wants to merge 3 commits intomainfrom
asinghvi17 wants to merge 3 commits intomainfrom
Conversation
but it actually increases runtime...something else is going on!
rafaqz
reviewed
Sep 20, 2024
This was referenced Sep 20, 2024
Member
|
Lots of licked cooky PRs here unfinished ;) Would be good to get all of these in |
Member
Author
|
I remember that this PR broke something just don't remember what. A nice side effect of this is that AoG will just work on any feature collection |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR treats FeatureCollections as row tables, and Features as rows.
so it's not great, but we can make it work. I'm still not sure how GeoJSON gets it so fast.