Add reshapeInput function wrapper#156
Merged
lostella merged 1 commit intoJuliaFirstOrder:masterfrom Mar 17, 2026
Merged
Conversation
hakkelt
force-pushed
the
add-reshape-input-function
branch
from
3a52102 to
c380b31
Compare
Contributor
Author
|
Hi @lostella, could you look at this PR? |
Member
|
@hakkelt thanks for the reminder! The wrapper looks quite generally useful and simple. Tests look good! |
lostella
approved these changes
Mar 17, 2026
Member
|
If there are no additional changes you would like to add, I would merge this |
Contributor
Author
|
Thanks, I don't want to add anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This calculus-type function is useful when the norm is already implemented, but it requires a specifically shaped input. For example, I work with 4D image arrays (3D medical images that change over time in the fourth dimension), and if I want to apply the proximal operator of the nuclear norm, I need to reshape them into a matrix before the operation.