Skip to content

Conversation

@hakkelt
Copy link
Contributor

@hakkelt hakkelt commented Nov 24, 2025

Generation of documentation was skipped because the optional field devbranch was set to "main" instead of "master". Deleting this keyword argument instructs Documenter.jl to figure out the correct branch name automatically.

Generation of documentation was skipped because the optional field `devbranch` was set to "main" instead of "master". Deleting this keyword argument instructs Documenter.jl to figure out the correct branch name automatically.
@lostella lostella merged commit f05b087 into JuliaFirstOrder:master Nov 24, 2025
10 checks passed
@lostella
Copy link
Member

@hakkelt I set the repo configs to deploy the pages from the gh-pages branch. I think that should be it? I don’t see the page yet at https://juliafirstorder.github.io/ProximalCore.jl/dev/

@lostella
Copy link
Member

Oh now I do, all good

@hakkelt
Copy link
Contributor Author

hakkelt commented Nov 24, 2025

Thanks! Could you release version 0.2.0?

@hakkelt hakkelt deleted the docs-fix branch November 24, 2025 15:31
@lostella
Copy link
Member

@lostella
Copy link
Member

@hakkelt the bump from 0.1.2 -> 0.2.0 is regarded as breaking. Is there actually anything breaking here? If not, we should probably name the release 0.1.3 (this came up since the registration needs release notes for merging)

@hakkelt
Copy link
Contributor Author

hakkelt commented Nov 25, 2025

Well, I don't think the changes are breaking in themselves, at not least technically, and I'm not strongly against v0.1.3. What I see why incrementing to v0.2.0 would be more clean because it would prevent the current ProximalOperators version (v0.16.1) that still have the moved functions to use this ProximalCore version. Although ProximalOperators v0.16.1 and the new ProximalCore version would most likely work together despite the duplicated functions, it might lead to confusion.

My suggestion is to bump ProximalCore to v0.2.0, but change the version of ProximalOperators in a non-breaking way. ProximalCore is currently unlikely to be used by anyone other than ProximalOperators and ProximalAlgorithms (at least, there is no other registered package that depends on it: https://juliapackages.com/p/proximalcore), so we are basically free to choose a version number.

@lostella
Copy link
Member

Makes sense, v0.2.0 is registered!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants