Skip to content

Make Pyramid applicable for putting this into Resampler#87

Closed
felixcremer wants to merge 4 commits intomainfrom
fc/makieresampler
Closed

Make Pyramid applicable for putting this into Resampler#87
felixcremer wants to merge 4 commits intomainfrom
fc/makieresampler

Conversation

@felixcremer
Copy link
Copy Markdown
Member

This is an experiment to make a Pyramid applicable so that we can then input it to a Makie.Resampler for plotting.

This needs

MakieOrg/Makie.jl#5485

for the fix of not being stuck at the finest resolution.

@SimonDanisch

this is for the fix in Makie for not being stuck at the highest zoom level
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 19.04762% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.46%. Comparing base (2ff01a7) to head (dd6f8df).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ext/PyramidSchemeMakieExt.jl 25.00% 12 Missing ⚠️
src/PyramidScheme.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   71.77%   68.46%   -3.31%     
==========================================
  Files           4        4              
  Lines         333      352      +19     
==========================================
+ Hits          239      241       +2     
- Misses         94      111      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixcremer
Copy link
Copy Markdown
Member Author

julia> img = Makie.loadasset("diffusemap.png")
┌ Warning: Output swatches are reduced due to the large size (1024×512).
│ Load the ImageShow package for large images.
└ @ Colors ~/.julia/packages/Colors/VFEJ1/src/display.jl:159

julia> red = collect(Float32,getproperty.(img, :r))
1024×512 Matrix{Float32}:
 0.45098  0.45098  0.45098  0.45098  0.45098  0.45098    0.45098   0.45098  0.45098  0.45098  0.45098
 0.45098  0.45098  0.45098  0.45098  0.45098  0.45098     0.45098   0.45098  0.45098  0.45098  0.45098
 0.45098  0.45098  0.45098  0.45098  0.45098  0.45098     0.45098   0.45098  0.45098  0.45098  0.45098
 0.45098  0.45098  0.45098  0.45098  0.45098  0.45098     0.45098   0.45098  0.45098  0.45098  0.45098
                                                                                           
 0.45098  0.45098  0.45098  0.45098  0.45098  0.45098     0.458824  0.45098  0.45098  0.45098  0.45098
 0.45098  0.45098  0.45098  0.45098  0.45098  0.45098     0.458824  0.45098  0.45098  0.45098  0.45098
 0.45098  0.45098  0.45098  0.45098  0.45098  0.45098     0.458824  0.45098  0.45098  0.45098  0.45098

julia> dd = DimArray(red, (X(1:size(red,1)), Y(1:size(red,2))))
┌ 1024×512 DimArray{Float32, 2} ┐
├───────────────────────────────┴───────────────────── dims ┐
   X Sampled{Int64} 1:1024 ForwardOrdered Regular Points,
   Y Sampled{Int64} 1:512 ForwardOrdered Regular Points
└───────────────────────────────────────────────────────────┘
         

julia> pyr = Pyramid(dd)
┌ Warning: The selected optimization algorithm requires second order derivatives, but `SecondOrder` ADtype was not provided. 
│         So a `SecondOrder` with ADTypes.AutoForwardDiff() for both inner and outer will be created, this can be suboptimal and not work in some cases so 
│         an explicit `SecondOrder` ADtype is recommended.
└ @ OptimizationBase ~/.julia/packages/OptimizationBase/ivotG/src/cache.jl:491024×512 Pyramid{Float32, 2} ┐
├──────────────────────────────┴────────────────────── dims ┐
   X Sampled{Int64} 1:1024 ForwardOrdered Regular Points,
   Y Sampled{Int64} 1:512 ForwardOrdered Regular Points
├───────────────────────────────────────────────── metadata ┤
  Dict{Any, Any} with 1 entry:
  "resampling_method" => "mean_skipmissing"
├──────────────────────────────────────────── pyramidlevels ┤
  Number of levels: 2 
   (1024, 512)
   (512, 256)
   (256, 128)
└───────────────────────────────────────────────────────────┘

julia> plot(pyr)

julia> res = Resampler(pyr)
Resampler{Pyramid{Float32, 2, Tuple{X{DimensionalData.Dimensions.Lookups.Sampled{Int64, UnitRange{Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Int64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}, Y{DimensionalData.Dimensions.Lookups.Sampled{Int64, UnitRange{Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Int64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}}, Matrix{Float32}, DimMatrix{Float32, Tuple{X{DimensionalData.Dimensions.Lookups.Sampled{Int64, UnitRange{Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Int64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}, Y{DimensionalData.Dimensions.Lookups.Sampled{Int64, UnitRange{Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Int64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}}, Tuple{}, Matrix{Float32}, DimensionalData.NoName, DimensionalData.Dimensions.Lookups.NoMetadata}, Vector{DimMatrix{Float32, Tuple{X{DimensionalData.Dimensions.Lookups.Sampled{Float64, LinRange{Float64, Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Float64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}, Y{DimensionalData.Dimensions.Lookups.Sampled{Float64, LinRange{Float64, Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Float64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}}, Tuple{}, Matrix{Float32}, DimensionalData.NoName, DimensionalData.Dimensions.Lookups.NoMetadata}}, Dict{Any, Any}}}(Float32[0.4509804 0.4509804 … 0.4509804 0.4509804; 0.4509804 0.4509804 … 0.4509804 0.4509804; … ; 0.4509804 0.4509804 … 0.4509804 0.4509804; 0.4509804 0.4509804 … 0.4509804 0.4509804], Makie.Automatic(), false, true)

julia> plot(res)
ERROR: No recipe for plot with args: Tuple{Resampler{Pyramid{Float32, 2, Tuple{X{DimensionalData.Dimensions.Lookups.Sampled{Int64, UnitRange{Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Int64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}, Y{DimensionalData.Dimensions.Lookups.Sampled{Int64, UnitRange{Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Int64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}}, Matrix{Float32}, DimMatrix{Float32, Tuple{X{DimensionalData.Dimensions.Lookups.Sampled{Int64, UnitRange{Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Int64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}, Y{DimensionalData.Dimensions.Lookups.Sampled{Int64, UnitRange{Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Int64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}}, Tuple{}, Matrix{Float32}, DimensionalData.NoName, DimensionalData.Dimensions.Lookups.NoMetadata}, Vector{DimMatrix{Float32, Tuple{X{DimensionalData.Dimensions.Lookups.Sampled{Float64, LinRange{Float64, Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Float64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}, Y{DimensionalData.Dimensions.Lookups.Sampled{Float64, LinRange{Float64, Int64}, DimensionalData.Dimensions.Lookups.ForwardOrdered, DimensionalData.Dimensions.Lookups.Regular{Float64}, DimensionalData.Dimensions.Lookups.Points, DimensionalData.Dimensions.Lookups.NoMetadata}}}, Tuple{}, Matrix{Float32}, DimensionalData.NoName, DimensionalData.Dimensions.Lookups.NoMetadata}}, Dict{Any, Any}}}}
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:44
 [2] plot!(::Plot{Makie.plot, Tuple{Resampler{Pyramid{Float32, 2, Tuple{}, Matrix{}, DimMatrix{}, Vector{}, Dict{}}}}})
   @ Makie ~/Documents/NFDI4Earth/plenary_2025/dev/Makie/Makie/src/interfaces.jl:134
 [3] connect_plot!(parent::Scene, plot::Plot{Makie.plot, Tuple{Resampler{Pyramid{}}}})
   @ Makie ~/Documents/NFDI4Earth/plenary_2025/dev/Makie/Makie/src/compute-plots.jl:842
 [4] plot!(scene::Scene, plot::Plot{Makie.plot, Tuple{Resampler{Pyramid{}}}})
   @ Makie ~/Documents/NFDI4Earth/plenary_2025/dev/Makie/Makie/src/interfaces.jl:211
 [5] plot!(ax::Axis, plot::Plot{Makie.plot, Tuple{Resampler{Pyramid{}}}})
   @ Makie ~/Documents/NFDI4Earth/plenary_2025/dev/Makie/Makie/src/figureplotting.jl:437
 [6] plot!(fa::Makie.FigureAxis, plot::Plot{Makie.plot, Tuple{Resampler{Pyramid{}}}})
   @ Makie ~/Documents/NFDI4Earth/plenary_2025/dev/Makie/Makie/src/figureplotting.jl:433
 [7] _create_plot(F::Function, attributes::Dict{Symbol, Any}, args::Resampler{Pyramid{…}})
   @ Makie ~/Documents/NFDI4Earth/plenary_2025/dev/Makie/Makie/src/figureplotting.jl:336
 [8] plot(args::Resampler{Pyramid{Float32, 2, Tuple{…}, Matrix{…}, DimMatrix{…}, Vector{…}, Dict{…}}})
   @ Makie ~/Documents/NFDI4Earth/plenary_2025/dev/Makie/Makie/src/recipes.jl:53
 [9] top-level scope
   @ REPL[42]:1
Some type information was truncated. Use `show(err)` to see complete types.

@felixcremer
Copy link
Copy Markdown
Member Author

I am closing this for now, because the recipe in the extension also works with WGLMakie and this has some strange behaviour that I don't see with the recipe in the extension.

@felixcremer felixcremer closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants