Merged
Conversation
navidcy
approved these changes
Mar 15, 2026
giordano
commented
Mar 15, 2026
Member
|
I've updated the secrets for Actions on GitHub, but for some reason the CDSAPI authentication is still failing. I tested locally and tests are passing. Merging and releasing a patch. |
Member
|
Patch released: JuliaRegistries/General#150547 I figured out the Action errors were specific to Windows. The authentication is probably different without CDSAPI keys. I've removed Windows from CI.yml and we should be green again on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompatHelper is disabled, so here's a manual PR. I can't test this because I don't have the credentials, but reading the JSON.jl migration guide, there shouldn't be significant breaking changes for the use of this package: only
JSON.jsonandJSON.parseare used, the former should be basically unaffected as far this package is concerned, the latter has the output type changed fromDicttoJSON.Object, but that's still anAbstractDict, so hopefully nothing needs to be changed here.A new version would be welcome after this PR is merged (I'm also bumping the version number here).