Skip to content

Allow JSON v1#67

Merged
juliohm merged 3 commits intoJuliaClimate:masterfrom
giordano:mg/json
Mar 15, 2026
Merged

Allow JSON v1#67
juliohm merged 3 commits intoJuliaClimate:masterfrom
giordano:mg/json

Conversation

@giordano
Copy link
Contributor

CompatHelper is disabled, so here's a manual PR. I can't test this because I don't have the credentials, but reading the JSON.jl migration guide, there shouldn't be significant breaking changes for the use of this package: only JSON.json and JSON.parse are used, the former should be basically unaffected as far this package is concerned, the latter has the output type changed from Dict to JSON.Object, but that's still an AbstractDict, so hopefully nothing needs to be changed here.

A new version would be welcome after this PR is merged (I'm also bumping the version number here).

@juliohm
Copy link
Member

juliohm commented Mar 15, 2026

I've updated the secrets for Actions on GitHub, but for some reason the CDSAPI authentication is still failing. I tested locally and tests are passing. Merging and releasing a patch.

@juliohm juliohm merged commit ec18864 into JuliaClimate:master Mar 15, 2026
0 of 12 checks passed
@giordano giordano deleted the mg/json branch March 15, 2026 10:34
@juliohm
Copy link
Member

juliohm commented Mar 15, 2026

Patch released: JuliaRegistries/General#150547

I figured out the Action errors were specific to Windows. The authentication is probably different without CDSAPI keys. I've removed Windows from CI.yml and we should be green again on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants