multiplication specialization for RectDiagonal and DiagonalFill#405
Open
Wu-Chenyang wants to merge 11 commits intoJuliaArrays:masterfrom
Open
multiplication specialization for RectDiagonal and DiagonalFill#405Wu-Chenyang wants to merge 11 commits intoJuliaArrays:masterfrom
Wu-Chenyang wants to merge 11 commits intoJuliaArrays:masterfrom
Conversation
…FillArrays.jl into rectdiagonal_multiplication
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
==========================================
- Coverage 99.48% 99.38% -0.11%
==========================================
Files 8 8
Lines 1157 1293 +136
==========================================
+ Hits 1151 1285 +134
- Misses 6 8 +2 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
There are two possible solutions for resolving the failed integration tests:
Tell me if any of these options is preferred, and I will make the changes. Besides, the pull request is now ready for review. Please let me know if any of the code is confusing or requires modification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the multiplication specialization for
RectDiagonalandDiagonalFillin accordance to the following table.It also implements the scalar multiplication of
RectDiagonalmentioned in #107.Incidentally, it implements some other related operations including:
TransposeandAdjointofRectDiagonalvec * adjoint(vec)andvec * transpose(vec)forAbstractFillVectorOneElementMatrixandDiagonalFill