Nested block indexing#482
Merged
dlfivefifty merged 10 commits intoJuliaArrays:masterfrom Oct 24, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
=======================================
Coverage 94.52% 94.53%
=======================================
Files 19 19
Lines 1789 1810 +21
=======================================
+ Hits 1691 1711 +20
- Misses 98 99 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@mtfishman I'm not sure if I've done the merging correctly or what can be done to get the tests passing.... |
Collaborator
Author
|
I can look into it, maybe some of the PRs conflicted with each other. |
Collaborator
Author
|
@dlfivefifty looks like it is fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables nested block indexing by generalizing
BlockIndexto allow indices that aren't integers, for example:As an alternative to just generalizing
BlockIndex, maybe we could define a new type such asGenericBlockIndexand then makeBlockIndexa type alias for that with the indices restricted to integers. I don't have a strong opinion about that but this design was simpler and I don't see much advantage one way or another.Related to #49 and #446, though note that in this PR the nested block structure isn't reflected in the axes, which would be required for more systematic support of nested block structures. This PR is split off from #462.